Page MenuHomePhabricator
Create Task
Maniphest T328133

Enable sticky header on talk pages (all namespaces)
Closed, ResolvedPublic
Actions

Description

In T304188: Enable sticky header on Talk pages (article and user talk), we enabled the Vector 2022 sticky header on talk page namespaces where DiscussionTools visual enhancements were already enabled. Then in T325417: Make Usability Improvements avail. in all talk namespaces , we enabled DiscussionTools visual enhancements on all talk namespaces. We should update the sticky header behavior to match.

Documentation at https://www.mediawiki.org/wiki/Reading/Web/Desktop_Improvements/Features/Sticky_Header#Why_is_the_sticky_header_not_showing_on_a_certain_page? should be updated afterwards.

Discussions:

Details

SubjectRepoBranchLines +/-
Enable sticky header on all talk pagesmediawiki/skins/Vectormaster+5 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jan 27 2023, 2:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2023, 2:37 PM
matmarex updated the task description. (Show Details)Jan 27 2023, 2:39 PM
gerritbot added a comment.Jan 27 2023, 2:51 PM

Change 884319 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Enable sticky header on all talk pages

https://gerrit.wikimedia.org/r/884319

gerritbot added a project: Patch-For-Review.Jan 27 2023, 2:51 PM
matmarex claimed this task.Jan 27 2023, 2:52 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.
matmarex added subscribers: Jdlrobson, ovasileva.
Jonesey95 subscribed.Jan 27 2023, 4:55 PM

To be clear: the request was for the sticky header to be enabled on ALL pages, not just all talk namespace pages. It should also show when I scroll down a diff page like this one. If it is going to be useful, it needs to appear where it is needed, which is pretty much everywhere.

Jdlrobson moved this task from Incoming to Search on the Desktop Improvements (Vector 2022) board.Jan 27 2023, 5:14 PM
gerritbot added a comment.Jan 27 2023, 8:22 PM

Change 884319 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Enable sticky header on all talk pages

https://gerrit.wikimedia.org/r/884319

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2023, 8:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 27 2023, 9:00 PM
matmarex added a comment.Jan 28 2023, 3:07 PM

(I replied about non-talk pages at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#c-Jonesey95-20230127165900-Matma_Rex-20230127143900)

matmarex moved this task from Doing to QA on the Editing-team (Kanban Board) board.Jan 28 2023, 3:08 PM
matmarex added a project: Editing QA.
Jonesey95 renamed this task from Enable sticky header on all talk pages to Enable sticky header on all pages.Jan 28 2023, 3:20 PM
matmarex added a comment.Feb 3 2023, 3:16 PM

I've looked at the meeting notes from Tuesday 31 January (I didn't attend): https://docs.google.com/document/d/16Cmu-Pm7S2P8c1A0lj5yPqshG8T-cJHAqfsc6trcu0U/edit and it seems to me that everyone agrees with you that the sticky header should appear in all namespaces.

matmarex added a comment.Feb 3 2023, 3:35 PM

There are also the other limitations, that no one has brought up yet: https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/61901f8b2dff539dc91b9f19fd60b1199cdd4ada/resources/skins.vector.es6/stickyHeader.js#514

  • Disabled on history action
  • Disabled on edit action (not submit though, so it appears in perview)
  • Disabled when viewing a diff

I couldn't figure out why they were added, but there's probably a reason.

Jonesey95 added a comment.Feb 3 2023, 5:04 PM

It is also disabled on the Watchlist, the page I visit the most. I would love to be able to see the sticky header, especially my notifications, as I scroll down the Watchlist.

Jdlrobson added a project: Web-Team-Backlog.Feb 14 2023, 6:44 PM
ppelberg renamed this task from Enable sticky header on all pages to Enable sticky header on talk pages (all namespaces).Feb 14 2023, 6:49 PM
matmarex updated the task description. (Show Details)Feb 14 2023, 6:59 PM
ppelberg mentioned this in T329673: Enable sticky header in all namespaces.Feb 14 2023, 8:09 PM
ppelberg added a parent task: T329673: Enable sticky header in all namespaces.
EAkinloose edited projects, added Verified; removed Editing QA.Feb 20 2023, 8:10 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Feb 22 2023, 9:33 PM
ovasileva triaged this task as Medium priority.Mar 1 2023, 11:28 PM
ovasileva moved this task from Not ready to estimate to Current Quarter on the Web-Team-Backlog board.
Jdlrobson added a comment.Mar 2 2023, 6:44 PM

This ticket can be resolved, I think?

Jonesey95 added a comment.Mar 2 2023, 9:27 PM

I think so, as long as T329673 makes progress.

Jdlrobson removed a project: Web-Team-Backlog.EditedMar 2 2023, 9:32 PM

T329673 is for enabling the sticky header in all namespaces (web team task)
T328133 is for enabling the sticky header in all talk namespaces (editing team task).

I've untagged backlog on this one as there is nothing for web team to do here.

Jonesey95 added a comment.Mar 2 2023, 9:47 PM
In T328133#8662171, @Jdlrobson wrote:

T328133 is for enabling the sticky header in all namespaces.

If so, it has a confusing title and description, and the bugs should maybe be merged. The sticky header needs to be enabled by default on all pages, including special pages like Watchlist and other Special: pages. Maybe that is not the scope of this task. What exactly is the scope of this task?

ppelberg closed this task as Resolved.Mar 4 2023, 12:42 AM
ppelberg subscribed.
In T328133#8662223, @Jonesey95 wrote:
In T328133#8662171, @Jdlrobson wrote:

T328133 is for enabling the sticky header in all namespaces.

If so, it has a confusing title and description, and the bugs should maybe be merged. The sticky header needs to be enabled by default on all pages, including special pages like Watchlist and other Special: pages. Maybe that is not the scope of this task. What exactly is the scope of this task?

This task involves the work of enabling the sticky header on all talk pages. The work to enable the sticky header on the pages you're describing in T328133#8585930 is covered by, as @Jdlrobson mentioned, T329673.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits