Page MenuHomePhabricator

remove config for showing constraints violations only to non-logged-in users
Open, Needs TriagePublic

Description

Problem:
As part of the IP masking investigation we discussed that constraints still have a config (WBQualityConstraintsShowConstraintViolationToNonLoggedInUsers) that let's us turn them off for non-logged-in users. This was intended as a temporary measure in case showing them to non-logged-in users would have an adverse effect. We have had them shown for everyone now for quite a while and no issues have come up. Let's remove the config.

On this property page: https://www.wikidata.org/wiki/Property:P31 the property 'different from' has a constraint violation. The setting should be completely removed.

Config was introduced with this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/874417

Acceptance criteria:

  • config for limiting constraint violation warnings to logged-in users is removed

Event Timeline

ArthurTaylor renamed this task from remove config for showing constraints violations only to non-logged-in users to [SW] remove config for showing constraints violations only to non-logged-in users.Feb 26 2024, 10:38 AM
ArthurTaylor renamed this task from [SW] remove config for showing constraints violations only to non-logged-in users to remove config for showing constraints violations only to non-logged-in users.Feb 28 2024, 10:11 AM
ArthurTaylor updated the task description. (Show Details)
ArthurTaylor updated the task description. (Show Details)
ArthurTaylor removed a project: wmde-wikidata-tech.

Does this work still need to be done?

I think it’s not a blocker for anything but we still want to do it.