Page MenuHomePhabricator

Disable fixed width on index namespace in Wikisource
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

We received a few requests to disable fixed article width within the index namespace in Wikisource. After reviewing the Vector 2022 skin on this namespace, we have decided to display items within it in full width, as they are similar to the table format on other special pages

Acceptance criteria

  • Disable fixed width on index namespace in Wikisource
  • Add code that corrects the fact that the index namespace number differs across projects like so:
I forgot about that the index namespace number varies based on wiki :-( Because of this the config change is less simple than expected. We'll move to next year.

Default value = 252
test2wiki, sourceswiki, enwikisource, arwikisource, aswikisource, bewikisource, eowikisource, cywikisource, dawikisource, fawikisource, guwikisource, huwikisource, hywikisource, 'knwikisource','lawikisource','mrwikisource','nlwikisource','nowikisource', 'rowikisource' 'ruwikisource' , 'sawikisource','tewikisource, 'viwikisource, 'zhwikisource= 106
vecwikisource, cawikisource, dewikisource, etwikisource, eswikisource,  frrwikisource,hrwikisource,	'mlwikisource','ptwikisource', 'pmswikisource 'slwikisource', = 104
bnwikisource, elwikisource, idwikisource, 'plwikisource = 102
brwikisource = 100
frwikisource, hewikisource = 112
itwikisource = 110
svwikisource = 108

QA

Event Timeline

ovasileva triaged this task as Medium priority.Nov 28 2023, 11:15 AM
Aklapper renamed this task from Disable fixed with on index namespace in Wikisource to Disable fixed width on index namespace in Wikisource.Nov 28 2023, 1:22 PM
Jdlrobson subscribed.

Vector 2022 currently supports this, we just need to make a backport to address this ($wgVectorMaxWidthOptions).

Jdlrobson set the point value for this task to 1.Dec 4 2023, 6:47 PM

Could we do this with the deploy tomorrow?

I forgot about that the index namespace number varies based on wiki :-( Because of this the config change is less simple than expected. We'll move to next year.

Default value = 252
test2wiki, sourceswiki, enwikisource, arwikisource, aswikisource, bewikisource, eowikisource, cywikisource, dawikisource, fawikisource, guwikisource, huwikisource, hywikisource, 'knwikisource','lawikisource','mrwikisource','nlwikisource','nowikisource', 'rowikisource' 'ruwikisource' , 'sawikisource','tewikisource, 'viwikisource, 'zhwikisource= 106
vecwikisource, cawikisource, dewikisource, etwikisource, eswikisource, frrwikisource,hrwikisource, 'mlwikisource','ptwikisource', 'pmswikisource 'slwikisource', = 104
bnwikisource, elwikisource, idwikisource, 'plwikisource = 102
brwikisource = 100
frwikisource, hewikisource = 112
itwikisource = 110
svwikisource = 108

ovasileva raised the priority of this task from Medium to High.Jan 4 2024, 4:46 PM
Jdlrobson removed the point value for this task.Jan 4 2024, 6:00 PM

Needs re-estimate.

ovasileva set the point value for this task to 2.Jan 8 2024, 6:36 PM
Jdlrobson updated the task description. (Show Details)

Change 989262 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[operations/mediawiki-config@master] Disable max width for index namespace

https://gerrit.wikimedia.org/r/989262

Change 989262 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable max width for index namespace

https://gerrit.wikimedia.org/r/989262

Mentioned in SAL (#wikimedia-operations) [2024-01-10T21:05:00Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:989262|Disable max width for index namespace (T352162)]]

Mentioned in SAL (#wikimedia-operations) [2024-01-10T21:08:37Z] <taavi@deploy2002> toyofuku and taavi: Backport for [[gerrit:989262|Disable max width for index namespace (T352162)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-01-10T21:19:20Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:989262|Disable max width for index namespace (T352162)]] (duration: 14m 19s)

Edtadros removed Edtadros as the assignee of this task.EditedJan 18 2024, 3:23 PM
Edtadros subscribed.

Test Result - Beta

Status: ✅ Pass
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Stepsi

Visit https://en.wikisource.org/wiki/Index:Singapore_Arms_and_Flag_and_National_Anthem_Rules_2003.pdf?useskin=vector-2022 on production , or https://en.wikisource.beta.wmflabs.org/wiki/Index:War_and_Peace.djvu?useskin=vector-2022 in beta in an incognito window.
✅ The page should be full screen.
The acceptance criteria states that fixed width would be disabled. This still allows me to toggle between full width and limited width. I wasn't sure what was meant by 'fixed width', I assumed it was full width, but limited width is still available. I misunderstood full-width. this is a pass.

screenshot 209.mov.gif (820×2 px, 1015 KB)

screenshot 210.mov.gif (820×2 px, 1 MB)

This is a pass per clarification during the web sync.

When I view an Index page, it now uses (nearly) the full width of the screen. When I go into edit mode, the width stays the same. But when I click Preview, for some strange reason the preview is narrower (on the right side).
This is especially evident on it.wikisource, which has a 3-columns layout for index pages, but it's noticeable on fr.wikisource as well.

I'm not reopening this task, as it seems a non-blocking issue, but it's rather odd and a bit confusing.

@Candalua which editor are you referring to? Could you share a screenshot of what you are seeing to help answer this question? There are some open bugs relating to preview and I can make sure this is covered by these once I have confirmed.