Page MenuHomePhabricator
Create Task
Maniphest T357152

[DOT] Perform necessary redirect after creating new lexeme with Special:NewLexeme
Closed, ResolvedPublic
Actions

Description

With T357024, the API will return a URL initialized by CentralAuth; we should redirect to this URL instead of the new lexeme (the URL will then redirect to the new lexeme once it’s finished setting up the temporary account).

The non-JS version of the special page also needs to be updated accordingly.

Details

SubjectRepoBranchLines +/-
Redirect for temp user in no-JS Special:NewLexememediawiki/extensions/WikibaseLexememaster+44 -3
Process CentralAuth redirects on new lexeme as TempUsermediawiki/extensions/WikibaseLexememaster+4 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 9 2024, 4:25 PM
Lucas_Werkmeister_WMDE mentioned this in T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions.
Lucas_Werkmeister_WMDE moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board.
Lucas_Werkmeister_WMDE mentioned this in T357024: [DOT] Add redirect-related parameters to API modules and return redirect URL (if any) in Wikibase editing APIs.Feb 9 2024, 4:35 PM
ArthurTaylor moved this task from Incoming to Unified DOT Backlog on the Wikidata Dev Team board.Feb 12 2024, 7:42 AM
Lucas_Werkmeister_WMDE moved this task from [DOT] By Project to [DOT] Prioritized on the wmde-wikidata-tech board.Feb 12 2024, 10:45 AM
ArthurTaylor claimed this task.Feb 13 2024, 8:09 AM
ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team.
ArthurTaylor moved this task from In Task Breakdown to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
Maintenance_bot moved this task from [DOT] Prioritized to Ongoing on the wmde-wikidata-tech board.Feb 13 2024, 8:29 AM
ArthurTaylor added a comment.Feb 13 2024, 12:02 PM

Created WIP PR https://github.com/wmde/new-lexeme-special-page/pull/640 pending implementation of API changes.

Lucas_Werkmeister_WMDE added a project: Wikidata Lexicographical data.Feb 14 2024, 9:28 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 15 2024, 10:15 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor subscribed.
ArthurTaylor assigned this task to LucasWerkmeister.Feb 20 2024, 8:45 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE claimed this task.Feb 20 2024, 9:39 AM
Lucas_Werkmeister_WMDE added a subscriber: LucasWerkmeister.
Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Feb 20 2024, 2:11 PM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Ready for Development on the Wikidata Dev Team (Wikidata.org Slice) board.

Moving back for updating the code + submodule in WikibaseLexeme.git.

gerritbot added a comment.Feb 21 2024, 9:29 AM

Change 1005445 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/WikibaseLexeme@master] Process CentralAuth redirects on new lexeme as TempUser

https://gerrit.wikimedia.org/r/1005445

gerritbot added a project: Patch-For-Review.Feb 21 2024, 9:29 AM
ArthurTaylor claimed this task.Feb 21 2024, 9:31 AM
ArthurTaylor moved this task from Ready for Development to In Development on the Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Feb 21 2024, 9:50 AM

Updated code + submodule in WikibaseLexeme.git

ArthurTaylor removed ArthurTaylor as the assignee of this task.Feb 21 2024, 9:50 AM
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Feb 21 2024, 5:00 PM
gerritbot added a comment.Feb 21 2024, 5:20 PM

Change 1005445 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Process CentralAuth redirects on new lexeme as TempUser

https://gerrit.wikimedia.org/r/1005445

Lucas_Werkmeister_WMDE added a comment.Feb 21 2024, 5:28 PM

Should be testable on Beta now.

gerritbot added a comment.Feb 26 2024, 11:06 AM

Change 1006491 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Redirect for temp user in no-JS Special:NewLexeme

https://gerrit.wikimedia.org/r/1006491

Lucas_Werkmeister_WMDE moved this task from Product Verification to Ready for Peer Review on the Wikidata Dev Team (Wikidata.org Slice) board.Feb 26 2024, 11:07 AM

Sorry, I just realized the no-JS version of the special page can also create lexemes and should also do the redirect.

hoo updated the task description. (Show Details)Feb 28 2024, 5:58 PM
hoo moved this task from Ready for Peer Review to Ready for Tech Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Feb 28 2024, 6:17 PM

Change 1006491 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Redirect for temp user in no-JS Special:NewLexeme

https://gerrit.wikimedia.org/r/1006491

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Feb 28 2024, 9:00 PM
Lucas_Werkmeister_WMDE mentioned this in T358754: Special:NewLexeme no longer redirects to created lexeme (unless a temporary account was created).Feb 29 2024, 11:42 AM
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board.Mar 4 2024, 10:54 AM

(I think this is more Product than Tech Verification.)

Arian_Bozorg closed this task as Resolved.Mar 4 2024, 3:04 PM
Arian_Bozorg claimed this task.
Arian_Bozorg subscribed.

This works for me! Thanks so much

Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board.Mar 4 2024, 3:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits