registered users
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	STran
	Feb 15 2024, 10:40 AM

Description

AbuseFilter filters occasionally want to distinguish between unlogged in users and users with accounts. No such filter exists although there are some workarounds. We should just make these filters explicit ahead of the temp accounts rollout because IPs won't be readily available anymore.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T357615 here

Details

	Subject	Repo	Branch	Lines +/-
	Add user_type variable	mediawiki/extensions/AbuseFilter	master	+154 -16

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 [Epic] Update features for temporary accounts
Open	Tchanders	T326869 Update TSP-owned products that may be affected by IP Masking
Resolved	• lbowmaker	T262321 IP Masking
Resolved	tstarling	T300263 [IP Masking] Create temporary account on first edit
Open	None	T307060 [Epic] Temporary account AbuseFilter support
Resolved	Dreamy_Jazz	T357615 Create filters to distinguish anonymous/temporary/registered users

Event Timeline

STran created this task.Feb 15 2024, 10:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2024, 10:40 AM

STran mentioned this in T331653: Investigate: Update AbuseFilter for IP Masking.Feb 15 2024, 1:07 PM

STran mentioned this in T357774: Investigate: What to do with existing filters that temporary accounts will break.Feb 16 2024, 2:05 PM

STran added a parent task: T331653: Investigate: Update AbuseFilter for IP Masking.Feb 16 2024, 2:08 PM

STran edited parent tasks, added: T307060: [Epic] Temporary account AbuseFilter support; removed: T331653: Investigate: Update AbuseFilter for IP Masking.

Dreamy_Jazz claimed this task.Feb 27 2024, 5:00 PM

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).

Change 1006965 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/AbuseFilter@master] [WIP] Add user_type variable

https://gerrit.wikimedia.org/r/1006965

gerritbot added a project: Patch-For-Review.Feb 27 2024, 5:25 PM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 27 2024, 5:26 PM

Dreamy_Jazz set the point value for this task to 2.Feb 28 2024, 12:28 AM

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

Dreamy_Jazz mentioned this in T358632: CannotCreateActorException when creating a temporary account on an edit which causes an abuse filter log.

Change 1006965 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Add user_type variable

https://gerrit.wikimedia.org/r/1006965

Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Mar 8 2024, 1:28 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2024, 1:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 8 2024, 2:00 PM

Suggested QA steps:

Create a filter with the sole condition as user_type = 'ip' set to log only
Disable temporary accounts on your wiki
Make a testing edit and verify that it matches the abuse filter (as evidenced by an entry in Special:AbuseLog)
Enable temporary accounts on your wiki
While logged out attempt to create a temporary account and verify that the account creation matched the abuse filter
Change the filter to be user_type = 'temp' (still set to log only)
Make an edit using your temporary account and verify that the edit matched the abuse filter
Change the filter to be user_type = 'named' (still set to log only)
Log into an account and make an edit, then verify that the edit matched the abuse filter

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)); removed Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)).Mar 11 2024, 3:16 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.

@Dreamy_Jazz Filters work as designed as seen in the videos below. I do have a question on the potential issue. As you see in the video, I disabled "Temp" filter and left "IP" and "Name" on. I then edit with a temp account and it showed in the Filter log under the "IP" filter even though "Temp" filter is disabled . Is that ok?

Status: ✅ PASS
Environment: Local: .42.0-alpha (d91c1e7) 14:25, 12 March 2024
OS: macOS Sonoma 14.2.1
Browser: Chrome 122
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Cat#
Special:AbuseFilter
Special:AbuseLog

✅AC1: https://phabricator.wikimedia.org/T357615

IP	Temp	Name

❓Pending potential issue

Temp filter disable with temp account edit

GMikesell-WMF updated the task description. (Show Details)Mar 12 2024, 9:59 PM

In T357615#9625143, @GMikesell-WMF wrote:

@Dreamy_Jazz Filters work as designed as seen in the videos below. I do have a question on the potential issue. As you see in the video, I disabled "Temp" filter and left "IP" and "Name" on. I then edit with a temp account and it showed in the Filter log under the "IP" filter even though "Temp" filter is disabled . Is that ok?
....
❓Pending potential issue

Temp filter disable with temp account edit

This is the expected behaviour, as AbuseFilter is run before the temporary account is created for the user. This may change in T359405: Create temporary account early in edit cycle for all edit attempts (so that the value of this variable would be temp on an edit which causes the creation of a temporary account).

In T357615#9625279, @Dreamy_Jazz wrote:

In T357615#9625143, @GMikesell-WMF wrote:

@Dreamy_Jazz Filters work as designed as seen in the videos below. I do have a question on the potential issue. As you see in the video, I disabled "Temp" filter and left "IP" and "Name" on. I then edit with a temp account and it showed in the Filter log under the "IP" filter even though "Temp" filter is disabled . Is that ok?
....
❓Pending potential issue

Temp filter disable with temp account edit

This is the expected behaviour, as AbuseFilter is run before the temporary account is created for the user. This may change in T359405: Create temporary account early in edit cycle for all edit attempts (so that the value of this variable would be temp on an edit which causes the creation of a temporary account).

Great, I will move this to Done. Thanks for the confirmation, steps, and all your work!

GMikesell-WMF updated the task description. (Show Details)Mar 13 2024, 4:25 PM

GMikesell-WMF moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.

Dreamy_Jazz closed this task as Resolved.Mar 14 2024, 1:40 PM

	F42582561: T357615_AbuseFilter_TempError.webm
	Mar 12 2024, 9:58 PM

	F42582431: T357615_AbuseFilter_Name.webm
	Mar 12 2024, 9:58 PM

	F42582429: T357615_AbuseFilter_Temp.webm
	Mar 12 2024, 9:58 PM

Create filters to distinguish anonymous/temporary/registered usersClosed, ResolvedPublic2 Estimated Story PointsActions