Page MenuHomePhabricator

Auto-comment on old revisions does not meet color contrast guidelines
Closed, ResolvedPublic0 Estimated Story Points

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • →‎This is a section! appears in gray and is unreadable.
  • This is also an issue in the day theme.

What should have happened instead?:

  • →‎This is a section! should be the same color as the rest of the text and meet AA guidelines.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

The rules in https://gerrit.wikimedia.org/g/mediawiki/core/+/a0fc7538f31e83e5ee9d345f05d7af19f2ec75f0/resources/src/mediawiki.interface.helpers.styles/linker.styles.less#55 are intended for display inside changes list

QA Results - Beta

ACStatusDetails
1T363878#9947495

QA Results - PROD

ACStatusDetails
1T363878#10018531

Event Timeline

I think this needs to use @color-placeholder rather than hardcoded value ?

This needs design. @color-placeholder doesn't seem to work for this context. Not sure if this is you or DST to work out?

This is a link, so please use color-progressive for this text.

This is not always a link. The autocomment can contain elements other than links - and the intention is to distinguish it from manually entered edit summaries. The link is only styled this way to be consistent with the surrounding text (for good or bad).

This style seems to have existed since before 2004, changed in 2017 from #808080; to #72777d; so I was unable to determine its history.

This is not always a link. The autocomment can contain elements other than links - and the intention is to distinguish it from manually entered edit summaries. The link is only styled this way to be consistent with the surrounding text (for good or bad).

This style seems to have existed since before 2004, changed in 2017 from #808080; to #72777d; so I was unable to determine its history.

Thanks for the additional context, Jon.
In this case, let's use color-subtle for these. Per T366861 the subtle will be more subtle in the upcoming codex release.

Jdlrobson renamed this task from Auto-comment on old revisions does not meet color contrast guidelines to [QA only] Auto-comment on old revisions does not meet color contrast guidelines.Jun 18 2024, 7:19 PM
Jdlrobson set the point value for this task to 0.

Appears to be fixed by T367438, so moving to QA.

@Jdlrobson "‎This is a section!" still appears in gray.

Test Result - Beta

Status:❌ FAIL
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&oldid=612901&minervanightmode=1
DarkLight
2024-07-02_15-33-24.png (542×3 px, 169 KB)
2024-07-02_15-32-51.png (537×3 px, 172 KB)
Jdlrobson added a subscriber: GMikesell-WMF.

@JScherer-WMF is this expected? Not sure if this corresponds with "disabled text". It seems like given the subtle color issues we've been discussing in Slack we may want to capture these in a new bug.

Jdlrobson renamed this task from [QA only] Auto-comment on old revisions does not meet color contrast guidelines to Auto-comment on old revisions does not meet color contrast guidelines.Jul 15 2024, 8:55 PM
Jdlrobson removed JScherer-WMF as the assignee of this task.

Hi DST, the issue here is that the automaticly generated comment is using --color-base--subtle which is not compatible with -background-color-warning-subtle (in dark mode). The intention with this is to distinguish between automatic comments and manually written ones.

Screenshot 2024-07-15 at 1.54.16 PM.png (228×1 px, 69 KB)

Screenshot 2024-07-15 at 1.55.17 PM.png (234×1 px, 70 KB)

If this is not an issue with the palette or the color choices, feel free to pass back to web team.

Change #1054620 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Linker: Do not use deprecated @color--base--subtle token

https://gerrit.wikimedia.org/r/1054620

If color-subtle is used instead of color-base--subtle (deprecated), then this is how warning message blocks will look in dark mode.

Screenshot 2024-07-16 at 11.50.45 AM.png (308×2 px, 91 KB)

Change #1054620 merged by jenkins-bot:

[mediawiki/core@master] Linker: Do not use deprecated @color--base--subtle token

https://gerrit.wikimedia.org/r/1054620

Test Result - PROD

Status:✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. Visit https://en.m.wikipedia.org/w/index.php?title=Basketball&oldid=1234125865
DarkLight
2024-07-16_16-17-31.png (682×3 px, 289 KB)
2024-07-16_16-18-24.png (703×3 px, 316 KB)

@GMikesell-WMF this should be trested as part of wmf.15 - it is not fixed yet. Looks like the test URL you used does not exhibit the problem described here. For production https://en.m.wikipedia.org/w/index.php?title=Spain&oldid=1233811524 can be used.

@Jdlrobson Sorry about that. Here are the most updated screenshots. Please let me know when I can retest again, thanks!

Test Result - PROD

Status: ❌ FAIL
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. https://en.m.wikipedia.org/w/index.php?title=Spain&oldid=1233811524
DarkLight
2024-07-23_10-13-30.png (928×3 px, 393 KB)
2024-07-23_10-12-31.png (1×3 px, 500 KB)

@GMikesell-WMF it's only in production now, looks fixed now? Can you retry? LGTM

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.3
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps
  1. https://en.m.wikipedia.org/w/index.php?title=Spain&oldid=1233811524
DarkLight
Screenshot 2024-07-26 at 8.55.32 AM.png (856×2 px, 401 KB)
Screenshot 2024-07-26 at 8.55.10 AM.png (868×2 px, 415 KB)