Page MenuHomePhabricator

WikibaseLexeme Cypress tests can time out too soon
Closed, ResolvedPublic

Description

Seen in this build for this unrelated change:

1) Lexeme:Lemma
     can be edited:
   AssertionError: Timed out retrying after 4000ms: Expected <button.lemma-widget_save.webfonts-changed> not to exist in the DOM, but it was continuously found.
    at LexemePage.headerSaveButtonNotPresent (webpack://WikibaseLexeme/./cypress/support/pageObjects/LexemePage.ts:168:0)
    at LexemePage.clickHeaderSaveButton (webpack://WikibaseLexeme/./cypress/support/pageObjects/LexemePage.ts:164:0)
    at LexemePage.setNthLemma (webpack://WikibaseLexeme/./cypress/support/pageObjects/LexemePage.ts:185:0)
    at Context.eval (webpack://WikibaseLexeme/./cypress/e2e/lemmaEdit.cy.ts:12:0)

4 seconds is not always enough time for the edit to be saved; in the WebdriverIO tests we use a timeout of 20 seconds for most commands (source), so we should bump the timeout in Cypress too.

Event Timeline

Change #1070947 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Increase Cypress defaultCommandTimeout to 20000 ms

https://gerrit.wikimedia.org/r/1070947

Change #1070947 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Increase Cypress defaultCommandTimeout to 20000 ms

https://gerrit.wikimedia.org/r/1070947