xdsclient: Populate total_issued_requests count in LRS load report #7544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
force-pushed
the
lrs-issued-count
branch
2 times, most recently
from
3f2280b
to
353a856
Compare
arjan-bal
force-pushed
the
lrs-issued-count
branch
from
353a856
to
0b6cafa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7544 +/- ##
==========================================
- Coverage 82.07% 81.85% -0.23%
==========================================
Files 360 361 +1
Lines 27533 27825 +292
==========================================
+ Hits 22599 22775 +176
- Misses 3759 3853 +94
- Partials 1175 1197 +22
|
arjan-bal
force-pushed
the
lrs-issued-count
branch
from
0b6cafa
to
5b14cb8
Compare
dfawley
reviewed
Aug 21, 2024
| assertString(xdsinternal.LocalityID{}.ToString): {RequestStats: load.RequestData{Succeeded: uint64(rpcCount - maxRequest + 50)}}, | ||
| assertString(xdsinternal.LocalityID{}.ToString): {RequestStats: load.RequestData{ | ||
| Succeeded: uint64(rpcCount - maxRequest + 50), | ||
| Issued: uint64(rpcCount - maxRequest + 50), |
There was a problem hiding this comment.
Are there no tests that include failed calls? It would be nice to have at least one test case where succeeded != issued.
There was a problem hiding this comment.
Changed a couple of test cases to have both errors and successful RPCs.
dfawley
reviewed
Aug 26, 2024
Comment on lines
187
to
188
| Succeeded: (rpcCount - dropCount) / 2, | ||
| Errored: (rpcCount - dropCount) / 2, |
There was a problem hiding this comment.
Can we make it so these aren't the same? I.e. if we reversed the two in code then the test would still pass. E.g. make it fail 1/4th and succeed in 3/4ths.
dfawley
approved these changes
Aug 26, 2024
arjan-bal
added a commit
to arjan-bal/grpc-go
that referenced
this pull request
Aug 26, 2024
…rpc#7544) * Populate isssued count in LRS load report * Test success, error and issued counts * Make pass/faiil fractions unequal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7538
This PR populates the total issued request count which is already being added by Java and c-core clients.
The
issued requestcounter is incremented when a new request is started. The counter is reset when a load report is sent to the LRS serverRELEASE NOTES:
total_issued_requestsfield.