fix(core): race between drop old JS listeners and create new listener…

…s on page load (#9144) * fix(core): race between drop old JS listeners and create new listeners on page load * Create fix-js-unlisten-all-race.md
tauri-apps · Mar 11, 2024 · 85de230 · 85de230
1 parent c3ea3a2
commit 85de230
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changes/fix-js-unlisten-all-race.md b/.changes/fix-js-unlisten-all-race.md
@@ -0,0 +1,5 @@
+---
+"tauri": patch:bug
+---
+
+Fix old JS listeners being dropped on page load after it was possible to create new listeners.
diff --git a/core/tauri/src/webview/mod.rs b/core/tauri/src/webview/mod.rs
@@ -571,7 +571,7 @@ tauri::Builder::default()
       .on_page_load_handler
       .replace(Box::new(move |url, event| {
         if let Some(w) = manager_.get_webview(&label_) {
-          if let PageLoadEvent::Finished = event {
+          if let PageLoadEvent::Started = event {
             w.unlisten_all_js();
           }
           if let Some(handler) = self.on_page_load_handler.as_ref() {