Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow setting product name and version on tauri.conf.json #1358

Merged
merged 7 commits into from
Mar 23, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Allows changing app name and version on tauri.conf.json. Allows app names with spaces on macOS and Windows, and simplifies this kind of change for devs not familiar with Rust.

@lucasfernog lucasfernog marked this pull request as ready for review March 18, 2021 01:19
@lucasfernog lucasfernog requested a review from a team as a code owner March 18, 2021 01:19
@lucasfernog lucasfernog requested review from a team March 18, 2021 01:19
@lucasfernog lucasfernog merged commit 5b3d9b2 into dev Mar 23, 2021
@lucasfernog lucasfernog deleted the feat/package-cfg branch March 23, 2021 00:51
jbolda added a commit that referenced this pull request Apr 11, 2021
* chore(deps) Update Tauri JS CLI (#1319)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Tauri Core (#1318)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Tauri API (#1316)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Rust crate serde_json to 1.0.64 (#1315)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Rust crate once_cell to 1.7.2 (#1314)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Rust crate image to 0.23.14 (#1313)

Co-authored-by: Renovate Bot <[email protected]>

* feat(cli/build): improve no distDir error message (#1306)

* feat(cli/build): improve no distDir error message

* chore: use Path's Display impl

Co-authored-by: Lucas Nogueira <[email protected]>

* chore(deps) Update Tauri API Definitions (#1317)

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>

* feat(bundler/wix): install webview2 runtime (#1329)

* feat(bundler/wix): install webview2 runtime

* add changefile

* chore(deps) Update Tauri API Definitions (major) (#1290)

* chore(deps) Update Tauri API Definitions

* chore: update to husky v5

* chore: remove husky script

* chore: recreate lock file

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>

* chore(deps) Update Tauri JS CLI (#1291)

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>

* refactor(core): app hooks (#1332)

* fix(api/window): rename manager export to appWindow (#1342)

* feat(api/shell): allow open command to open files (#1341)

* chore(deps) Update Tauri API Definitions (#1344)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Rust crate tokio to 1.3 (#1343)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Rust crate open to 1.6.0 (#1348)

Co-authored-by: Renovate Bot <[email protected]>

* fix(core): wrong usage of wry RPC on event API (#1351)

* copy cli config definition window visibility defaults (#1353)

* feat(core): add file drop handler (#1352)

* fix: get correct resource dir in AppImge (fix #1308) (#1333)

Co-authored-by: Lucas Nogueira <[email protected]>

* feat: build without proc macros (#1226)

Co-authored-by: Lucas Nogueira <[email protected]>

* chore(deps) Update Tauri JS CLI (#1346)

Co-authored-by: Renovate Bot <[email protected]>

* refactor(core): use Mutex in std to reduce async usage (#1350)

Co-authored-by: Lucas Nogueira <[email protected]>

* fix(examples): build error (#1354)

Co-authored-by: Lucas Nogueira <[email protected]>

* API example new ui (#1310)

Co-authored-by: Lucas Nogueira <[email protected]>

* chore(deps): remove `winres` from template (#1357)

* refactor(core): add `unlisten`, `once` APIs to the event system (#1359)

* fix(cli): use correct arg in `_blanks` links polyfill (#1362)

* fix(api/http): correct types (#1360)

* fix(api/http): correct types

* Add changes

* Update correct-http-api-types.md

* chore(deps) Update Tauri JS CLI (#1364)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Tauri API Definitions (#1363)

Co-authored-by: Renovate Bot <[email protected]>

* fix(tauri/webview): Use different user_data_path for Windows (#1365) (#1366)

Co-authored-by: Lucas Nogueira <[email protected]>

* fix(config): serde_json::Value::Object takes a Map instead of HashMap (#1371)

* fix(config): serde_json::Value::Object takes a Map instead of HashMap

* fix: fmt

* fix(tauri.js): init command properly building with manifests (#1374)

* fix(tauri.js): init command properly building with manifests

* fix: tests

* feat(bundler): add visual c++ redistributable files with MSM (#1368)

* refactor(core): reduce usage on arc and mutex (#1361)

Co-authored-by: Lucas Nogueira <[email protected]>

* feat(config): allow setting product name and version on tauri.conf.json (#1358)

* feat: add current working directory to path api module (#1375)

* refactor(core): move bundle script to /tauri crate (#1377)

* refactor(core): move bundle script to /tauri crate

* fix(cli): clippy

* fix(core): tests

* refactor(core): custom protocol URL uses the app identifier (#1376)

* refactor(core): custom protocol URL uses the app identifier

* fix: clippy

* fix(tauri-api): remove .exe from app_name on windows (#1379)

* chore(deps) Update Tauri API Definitions (#1384)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Rust crate tokio to 1.4 (#1383)

Co-authored-by: Renovate Bot <[email protected]>

* fix(cli): prmpt user before install deps in init (#1381)

Co-authored-by: Lucas Nogueira <[email protected]>

* chore(deps) Update dependency rollup to v2.42.4 (#1386)

Co-authored-by: Renovate Bot <[email protected]>

* refactor(cli): rewrite init command in Rust (#1382)

Co-authored-by: nothingismagick <[email protected]>

* refactor(bundler): specific settings on dedicated structs, update README (#1380)

* replace lazy_static uses with once_cell (#1391)

* chore(deps) Update Tauri JS CLI (#1385)

Co-authored-by: Renovate Bot <[email protected]>

* refactor(cli): rewrite info in Rust (#1389)

* refactor(core): remove async from app hooks, add InvokeMessage type (#1392)

* fix(cli): disable custom-protocol feature on dev command (#1393)

* Fix extremely slow dev builds caused by embedding + compressing assets at compile time (#1395)

* feat(bundler) code signing (#473)

Co-authored-by: Rajiv Shah <[email protected]>
Co-authored-by: David Lemarier <[email protected]>

* feat(cli): run beforeDev and beforeBuild in a shell, closes #1295 (#1399)

* update to sharp 0.28.0 for cpu arm (m1) (#1404)

Co-authored-by: Lucas Nogueira <[email protected]>

* feat(cli): propagate args passed after `dev --`, closes #1406 (#1407)

* refactor(api): use secure RNG, closes #1356 (#1398)

* chore(deps) Update Tauri API Definitions (#1411)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Rust crate rfd to 0.2.2 (#1410)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Tauri CLI (#1413)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Tauri Bundler (#1412)

Co-authored-by: Renovate Bot <[email protected]>

* refactor(core): rewrite shell execute API, closes #1229 (#1408)

* chore(deps) Update dependency @rollup/plugin-commonjs to v18 (#1415)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps) Update Tauri JS CLI (#1414)

Co-authored-by: Renovate Bot <[email protected]>

* fix: asset resolution on debug mode

* fix(core): ignore query string on custom protocol asset resolver (#1420)

* wire up existing and adjust recipe configuration

* merge dev

* fix default app name

* clean up vanillajs and proper pass args

* use scaffe to copy the react templates

* fix(api): remove cjs, rename .mjs to .js

* chore: tauri.js dead code elim (#1422)

* remove templates, only used it CTA

* help command is empty, remove

* delete files that aren't imported / required

* set files array to ignore src and config files

* remove unused deps

* add arch notes for future ref

* change file

* allow specifying a binary

* resolve last bits to reach scaffe

* adjust vanilla js template dir path

Co-authored-by: Sanket Chaudhari <[email protected]>

* fix up cra scaffolding

* remove none and rely on vanillajs

* log shell commands

* remove no recipe question branch

* shift react template for better overwrite copying

* update deps

* simple readme

* implement dep manager

* pretty

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Noah Klayman <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>
Co-authored-by: Lucas Fernandes Nogueira <[email protected]>
Co-authored-by: chip <[email protected]>
Co-authored-by: Gabe Cohen <[email protected]>
Co-authored-by: Ngo Iok Ui (Wu Yu Wei) <[email protected]>
Co-authored-by: Alve Larsson <[email protected]>
Co-authored-by: Amr Bashir <[email protected]>
Co-authored-by: Kid <[email protected]>
Co-authored-by: david <[email protected]>
Co-authored-by: nothingismagick <[email protected]>
Co-authored-by: William <[email protected]>
Co-authored-by: Rajiv Shah <[email protected]>
Co-authored-by: Mehdi Rezaei <[email protected]>
Co-authored-by: Sanket Chaudhari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant