inject css with template string to allow for line breaks #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alternative solution would to be implement a struct `JsStringLiteral` with `fmt::Display` that escapes all forbidden codepoints from the spec https://www.ecma-international.org/ecma-262/#sec-literals-string-literals template string literal seems fine as all browsers that tauri supports have had support for them for the past 3-4+ years Signed-off-by: Chip Reed <[email protected]>
lucasfernog
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
No change file because there hasn't been a release since the last commit that changed this behavior. (e3e2e39)
An alternative solution would to be implement a struct
JsStringLiteralwith afmt::Displaythat escapes all forbidden codepoints detailed in the spec: https://www.ecma-international.org/ecma-262/#sec-literals-string-literalsAn approach very similar to this was previously used to escape css content injected inside of the webview crate. (the one before
webview_official)Template string literal fix seems to be by far the simplest change to fix it. All browsers that tauri supports (the webview browsers) have had support for them for the past 3-4+ years.
I didn't catch this during e3e2e39 because my css was minified with no newlines.