-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cygwin support #2610
feat: add cygwin support #2610
Conversation
All reactions
-
❤️ 1 reaction
b97de9a
to
c27a42e
Compare
The CI is broken:( |
All reactions
Sorry, something went wrong.
Weird, let me take a look |
All reactions
Sorry, something went wrong.
Hello, @SteveLauC , if you are still looking at this:) I think it's because the latest version of |
All reactions
Sorry, something went wrong.
So was this newer version of |
All reactions
Sorry, something went wrong.
I don't think so. This repo doesn't commit the However, it seems that |
All reactions
Sorry, something went wrong.
Just re-ran the CI, and they failed because |
All reactions
Sorry, something went wrong.
Weird, the FreeBSD CI was still using once_cell 1.21.0 🤔 https://github.com/nix-rust/nix/pull/2610/checks?check_run_id=38692242745 |
All reactions
Sorry, something went wrong.
Failed 5 days ago. Not today. |
All reactions
Sorry, something went wrong.
Hmm, sorry for missing that:D |
All reactions
Sorry, something went wrong.
Thank you @SteveLauC , now the CI passes again. |
All reactions
-
❤️ 1 reaction
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, the code part looks good. For the tests, some of them are "ignored" even though the corresponding symbols are available, I would like to know why, and if possible, it would be great to comment on the reason there, which would help maintenance a lot! :)
Sorry, something went wrong.
All reactions
Let me fix the unrelated nightly clippy warning |
All reactions
Sorry, something went wrong.
They pass on Cygwin, but not on MSYS2 as intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sorry, something went wrong.
What does this PR do
This PR adds cygwin target support.
Tracking:
Checklist:
CONTRIBUTING.md