Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add std support to cygwin target #137621

Merged
merged 13 commits into from
Mar 17, 2025
Merged

Add std support to cygwin target #137621

merged 13 commits into from
Mar 17, 2025
+197 −19

Conversation

Berrysoft
Copy link
Contributor

@Berrysoft Berrysoft commented Feb 25, 2025 •
edited
Loading

Page not found · GitHub · GitHub
Skip to content
404 “This is not the web page you are looking for”
Contact Support — GitHub Status — @githubstatus
@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 25, 2025
@Berrysoft Berrysoft changed the title Cygwin std Add std support to cygwin target Feb 25, 2025
@Berrysoft Berrysoft mentioned this pull request Feb 25, 2025
Open
7 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Berrysoft Berrysoft mentioned this pull request Feb 28, 2025
Merged
@Kreijstal
Copy link

Thank you!

@workingjubilee workingjubilee mentioned this pull request Feb 28, 2025
Open
3 tasks
joboet
joboet reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@joboet joboet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This looks really good to me – I can't help but be impressed by the astounding level of support that Cygwin has for even niche POSIX APIs...

@Berrysoft Berrysoft marked this pull request as ready for review March 7, 2025 15:26
@rustbot
Copy link
Collaborator

rustbot commented Mar 7, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@Berrysoft Berrysoft requested a review from joboet March 7, 2025 15:26
This was referenced Mar 7, 2025
Open
Merged
josephlr added a commit to rust-random/getrandom that referenced this pull request Mar 9, 2025
@Berrysoft @josephlr
Add cygwin support (#626)
526aff1 
Need rust-lang/rust#137621 to test.

---------

Co-authored-by: Joe Richey <dev@richey.us>
@bors
Copy link
Contributor

bors commented Mar 9, 2025

☔ The latest upstream changes (presumably #138279) made this pull request unmergeable. Please resolve the merge conflicts.

@joboet
Copy link
Member

joboet commented Mar 11, 2025

Great, thank you!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 11, 2025

📌 Commit 9cab8c2 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025
@Berrysoft Berrysoft mentioned this pull request Mar 11, 2025
Merged
3 tasks
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025
@jieyouxu
Rollup merge of rust-lang#137621 - Berrysoft:cygwin-std, r=joboet
5017577 
Add std support to cygwin target
@jieyouxu jieyouxu mentioned this pull request Mar 12, 2025
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 12, 2025
@jieyouxu
Rollup merge of rust-lang#137621 - Berrysoft:cygwin-std, r=joboet
8d52064 
Add std support to cygwin target
@jieyouxu jieyouxu mentioned this pull request Mar 12, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2025
@bors
Auto merge of rust-lang#138383 - jieyouxu:rollup-ntnvzmn, r=jieyouxu
74d92df 
Rollup of 25 pull requests

Successful merges:

 - rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`)
 - rust-lang#136842 (Add libstd support for Trusty targets)
 - rust-lang#137314 (change definitely unproductive cycles to error)
 - rust-lang#137504 (Move methods from Map to TyCtxt, part 4.)
 - rust-lang#137621 (Add std support to cygwin target)
 - rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`)
 - rust-lang#138109 (make precise capturing args in rustdoc Json typed)
 - rust-lang#138161 (Add PeekMut::refresh)
 - rust-lang#138162 (Update the standard library to Rust 2024)
 - rust-lang#138174 (Elaborate trait assumption in `receiver_is_dispatchable`)
 - rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj)
 - rust-lang#138269 (uefi: fs: Implement FileType, FilePermissions and FileAttr)
 - rust-lang#138313 (Update books)
 - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js)
 - rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more)
 - rust-lang#138333 (Rebuild llvm spuriously less frequently)
 - rust-lang#138343 (Enable `f16` tests for `powf`)
 - rust-lang#138345 (Some autodiff cleanups)
 - rust-lang#138346 (naked functions: on windows emit `.endef` without the symbol name)
 - rust-lang#138347 (Reduce `kw::Empty` usage, part 2)
 - rust-lang#138360 (Fix false-positive in `expr_or_init` and in the `invalid_from_utf8` lint)
 - rust-lang#138371 (Update compiletest's `has_asm_support` to match rustc)
 - rust-lang#138372 (Refactor `pick2_mut` & `pick3_mut` to use `get_disjoint_mut`)
 - rust-lang#138376 (Item-related cleanups)
 - rust-lang#138377 (Remove unnecessary lifetime from `PatInfo`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@Berrysoft
Copy link
Contributor Author

Thank you for your approval @joboet, but I have pushed one more commit to fix the panic handling for cygwin. It should be the same as *-windows-gnu.

@Berrysoft
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2025
@Berrysoft
Copy link
Contributor Author

@rustbot label -S-waiting-on-bors

@rustbot rustbot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 13, 2025
@joboet
Copy link
Member

joboet commented Mar 17, 2025

@bors r+

@bors
Copy link
Contributor

bors commented Mar 17, 2025

📌 Commit bd385f3 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2025
@jhpratt jhpratt mentioned this pull request Mar 17, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2025
@bors
Auto merge of rust-lang#138595 - jhpratt:rollup-09pvfzu, r=jhpratt
9c67cec 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#136355 (Add `*_value` methods to proc_macro lib)
 - rust-lang#137621 (Add std support to cygwin target)
 - rust-lang#137793 (Stablize anonymous pipe)
 - rust-lang#138341 (std: Mention clone-on-write mutation in Arc<T>)
 - rust-lang#138517 (Improve upvar analysis for deref of child capture)
 - rust-lang#138584 (Update Rust Foundation links in Readme)
 - rust-lang#138586 (Document `#![register_tool]`)
 - rust-lang#138590 (Flatten and simplify some control flow 🫓)
 - rust-lang#138592 (update change entry for rust-lang#137147)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b3b7a3b into rust-lang:master Mar 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 17, 2025
@Berrysoft Berrysoft deleted the cygwin-std branch March 17, 2025 13:56
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2025
@rust-timer
Unrolled build for rust-lang#137621
1efbe7f 
Rollup merge of rust-lang#137621 - Berrysoft:cygwin-std, r=joboet

Add std support to cygwin target
@Kreijstal
Copy link

finally :)

riking
riking reviewed Mar 21, 2025
View reviewed changes
library/std/src/sys/net/connection/socket/unix.rs
pub fn set_linger(&self, linger: Option<Duration>) -> io::Result<()> {
let linger = libc::linger {
l_onoff: linger.is_some() as libc::c_ushort,
l_linger: linger.unwrap_or_default().as_secs() as libc::c_ushort,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a try_into().map_error(|_| libc::ERANGE)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just an imitation of the code above, for other platforms. Other platforms also use as.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riking riking

@joboet joboet

Assignees

@joboet joboet

Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Berrysoft @rustbot @rust-log-analyzer @Kreijstal @bors @joboet @riking