Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc js: add nonnull helper and typecheck src-script.js #138468

Merged

Conversation

lolbinarycat
Copy link
Contributor

this removes @ts-nocheck from src-script.js and adds a nonnull helper function that assists in adding null checks to places where null values should be impossible.

r? @notriddle

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Mar 13, 2025
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-js-less-expect-error-part3 branch from bca2ce2 to a70468f Compare March 13, 2025 20:12
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-js-less-expect-error-part3 branch from a70468f to 46ed2ad Compare March 13, 2025 21:09
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-js-less-expect-error-part3 branch from 46ed2ad to d8d9b75 Compare March 13, 2025 21:41
@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-js-less-expect-error-part3 branch from d8d9b75 to 409510c Compare March 14, 2025 19:40
@notriddle
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 22, 2025

📌 Commit 409510c has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138018 (rustdoc: Use own logic to print `#[repr(..)]` attributes in JSON output.)
 - rust-lang#138294 (Mark some std tests as requiring `panic = "unwind"`)
 - rust-lang#138468 (rustdoc js: add nonnull helper and typecheck src-script.js)
 - rust-lang#138675 (Add release notes for 1.85.1)
 - rust-lang#138765 (Fix Thread::set_name on cygwin)
 - rust-lang#138786 (Move some driver code around)
 - rust-lang#138793 (target spec check: better error when llvm-floatabi is missing)
 - rust-lang#138822 (De-Stabilize `file_lock`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 26ecbc6 into rust-lang:master Mar 23, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 23, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
Rollup merge of rust-lang#138468 - lolbinarycat:rustdoc-js-less-expect-error-part3, r=notriddle

rustdoc js: add nonnull helper and typecheck src-script.js

this removes ``@ts-nocheck`` from `src-script.js` and adds a `nonnull` helper function that assists in adding null checks to places where null values should be impossible.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants