Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 1.85.1 #138675

Merged
merged 2 commits into from
Mar 23, 2025
Merged

Add release notes for 1.85.1 #138675

merged 2 commits into from
Mar 23, 2025

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Mar 18, 2025

Closes #138819.

@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Mar 18, 2025
@Urgau
Copy link
Member

Urgau commented Mar 22, 2025

I'm not in T-release, but since same changes are already in the stable branch and that we are 4 days late. I'm going to approve it, as to avoid more confused users, #138819.

Btw, I know we generally have a no self-approve PR policy but I think in this case (which is basically just a backport) it's fine to self-approve.

@bors r+ p=1 rollup

@bors
Copy link
Contributor

bors commented Mar 22, 2025

📌 Commit 1f64cb7 has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2025
@jieyouxu
Copy link
Member

Edited PR description to close the issue.

RELEASES.md Outdated

- [Fix the doctest-merging feature of the 2024 Edition.](https://github.com/rust-lang/rust/pull/137899/)
- [Relax some `target_feature` checks when generating docs.](https://github.com/rust-lang/rust/pull/137632/)
- [Fix errors in `std::fs::rename` on Windows 1607.](https://github.com/rust-lang/rust/pull/137528/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter much but it's been pointed out to me that this should rightly be "Windows 10, version 1607" to avoid confusing it with the year 1607. We don't officially support Windows versions that far back so there shouldn't be any real ambiguity but it does make sense to be accurate. But it's no big deal either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] to avoid confusing it with the year 1607. We don't officially support Windows versions that far back [...]

Hmm, is that why the Window epoch starts in 1601? 🤔

@cuviper
Copy link
Member Author

cuviper commented Mar 22, 2025

Clarified "Windows 1607".

@bors r=Urgau

@bors
Copy link
Contributor

bors commented Mar 22, 2025

📌 Commit f39478f has been approved by Urgau

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 22, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138018 (rustdoc: Use own logic to print `#[repr(..)]` attributes in JSON output.)
 - rust-lang#138294 (Mark some std tests as requiring `panic = "unwind"`)
 - rust-lang#138468 (rustdoc js: add nonnull helper and typecheck src-script.js)
 - rust-lang#138675 (Add release notes for 1.85.1)
 - rust-lang#138765 (Fix Thread::set_name on cygwin)
 - rust-lang#138786 (Move some driver code around)
 - rust-lang#138793 (target spec check: better error when llvm-floatabi is missing)
 - rust-lang#138822 (De-Stabilize `file_lock`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8986c53 into rust-lang:master Mar 23, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 23, 2025
@bors
Copy link
Contributor

bors commented Mar 23, 2025

⌛ Testing commit f39478f with merge 756bff9...

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
Rollup merge of rust-lang#138675 - cuviper:release-1.85.1, r=Urgau

Add release notes for 1.85.1

Closes rust-lang#138819.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust 1.85.1 not marked as released on GitHub
7 participants