Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass CI_JOB_DOC_URL to Docker #138487

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Pass CI_JOB_DOC_URL to Docker #138487

merged 1 commit into from
Mar 14, 2025
+1 −0

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 14, 2025 •
edited
Loading

Fix-up for #136911. I always forget to pass new environment variables to Docker images.. 🤦‍♂️

r? @marcoieni

try-job: x86_64-fuchsia

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 14, 2025
marcoieni
marcoieni approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to r=me

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 14, 2025

Let's try it.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
@bors
Auto merge of rust-lang#138487 - Kobzol:fix-doc-url-docker, r=<try>
d8fdaa8 
Pass `CI_JOB_DOC_URL` to Docker

Fix-up for rust-lang#136911. I always forget to pass new environment variables to Docker images.. 🤦‍♂️

r? `@marcoieni`

try-job: x86_64-fuchsia
@bors
Copy link
Contributor

bors commented Mar 14, 2025

⌛ Trying commit 7afad54 with merge d8fdaa8...

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 14, 2025 •
edited
Loading

Looks fine, the URL has been printed to the log. Cancelling the try build now.

@bors
Copy link
Contributor

bors commented Mar 14, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 14, 2025

@bors r=marcoieni rollup

@bors
Copy link
Contributor

bors commented Mar 14, 2025

📌 Commit 7afad54 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 14, 2025
@fmease fmease mentioned this pull request Mar 14, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
@bors
Auto merge of rust-lang#138506 - fmease:rollup-ve4h2eq, r=fmease
ecade53 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#134720 (Display valid crate types in error message for --crate-type flag)
 - rust-lang#137619 (Provide helpful diagnostics for shebang lookalikes)
 - rust-lang#138353 (remove must_use from <*const T>::expose_provenance)
 - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`)
 - rust-lang#138469 (remove comment regarding a removed test directive)
 - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`)
 - rust-lang#138485 (Rustc dev guide subtree update)
 - rust-lang#138487 (Pass `CI_JOB_DOC_URL` to Docker)
 - rust-lang#138495 (Take a break from reviews)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c5e3857 into rust-lang:master Mar 14, 2025
6 of 7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 14, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
@rust-timer
Unrolled build for rust-lang#138487
2e45b52 
Rollup merge of rust-lang#138487 - Kobzol:fix-doc-url-docker, r=marcoieni

Pass `CI_JOB_DOC_URL` to Docker

Fix-up for rust-lang#136911. I always forget to pass new environment variables to Docker images.. 🤦‍♂️

r? `@marcoieni`

try-job: x86_64-fuchsia
@Kobzol Kobzol deleted the fix-doc-url-docker branch March 14, 2025 20:17
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 19, 2025
@bors
Auto merge of rust-lang#138506 - fmease:rollup-ve4h2eq, r=fmease
924a1b7 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#134720 (Display valid crate types in error message for --crate-type flag)
 - rust-lang#137619 (Provide helpful diagnostics for shebang lookalikes)
 - rust-lang#138353 (remove must_use from <*const T>::expose_provenance)
 - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`)
 - rust-lang#138469 (remove comment regarding a removed test directive)
 - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`)
 - rust-lang#138485 (Rustc dev guide subtree update)
 - rust-lang#138487 (Pass `CI_JOB_DOC_URL` to Docker)
 - rust-lang#138495 (Take a break from reviews)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoieni marcoieni

Assignees

@marcoieni marcoieni

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Kobzol @bors @marcoieni @rustbot