Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustc dev guide subtree update #138485

Merged
merged 34 commits into from
Mar 14, 2025
Merged

Rustc dev guide subtree update #138485

merged 34 commits into from
Mar 14, 2025

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Mar 14, 2025

fee1-dead and others added 30 commits February 20, 2025 21:39
Don't suggest explicitly `cfg`-gating `trace!` calls in bootstrap
- There is more than just target and stage
- There is only 3 stages, so don't mention them specially
compiletest directives: ignore-stage0 and only-stage0 do not exist
already mentioned before showing code snippet
Document `fetch.prunetags = true` gotcha during rustc-pull
This compiletest directive was removed in rust-lang#120265.
@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@jieyouxu
Copy link
Member

Thanks, the shape of the commits and time looks right to me.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 14, 2025

📌 Commit 3d9bf08 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang#134720 (Display valid crate types in error message for --crate-type flag)
 - rust-lang#137619 (Provide helpful diagnostics for shebang lookalikes)
 - rust-lang#138353 (remove must_use from <*const T>::expose_provenance)
 - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`)
 - rust-lang#138469 (remove comment regarding a removed test directive)
 - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`)
 - rust-lang#138485 (Rustc dev guide subtree update)
 - rust-lang#138487 (Pass `CI_JOB_DOC_URL` to Docker)
 - rust-lang#138495 (Take a break from reviews)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8eeecb7 into rust-lang:master Mar 14, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 14, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2025
Rollup merge of rust-lang#138485 - BoxyUwU:rdg-push, r=jieyouxu

Rustc dev guide subtree update

r? `@jieyouxu`
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Mar 19, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang#134720 (Display valid crate types in error message for --crate-type flag)
 - rust-lang#137619 (Provide helpful diagnostics for shebang lookalikes)
 - rust-lang#138353 (remove must_use from <*const T>::expose_provenance)
 - rust-lang#138452 (Remove `RUN_CHECK_WITH_PARALLEL_QUERIES`)
 - rust-lang#138469 (remove comment regarding a removed test directive)
 - rust-lang#138477 (Deny impls for `BikeshedGuaranteedNoDrop`)
 - rust-lang#138485 (Rustc dev guide subtree update)
 - rust-lang#138487 (Pass `CI_JOB_DOC_URL` to Docker)
 - rust-lang#138495 (Take a break from reviews)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet