Rollup of 7 pull requests #138653
Merged
Rollup of 7 pull requests #138653
+254
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Predrag Gruevski <obi1kenobi82@gmail.com>
exit: document interaction with C Cc rust-lang#126600
…youxu Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml` I was curious as to the possible bootstrap options I can put in config.toml, but had some trouble figuring it out. There is no obvious documentation in `config.toml` (obviously), the documentation in src/bootstrap/defaults is *nice*, but also rather sparse, by design. I had to dive into the parsing code, and stuble upon [a very helpful doc comment](https://github.com/rust-lang/rust/blob/30f168ef811aec63124eac677e14699baa9395bd/src/bootstrap/src/core/config/config.rs#L181) there to realize that `config.example.toml` *exists*, and that it does, indeed, answer all of my questions. So I figured it might be worth making this journey a bit easier for future contributors and add mention the `config.example.toml` directly in `config.toml`. Now, since rust-lang#137081 is in-flight which would rename `config(.example)?.toml` to `bootstrap(.example)?.toml`, I figure it's better to wait until that one lands, and submit the "new", "correct" filename upfront, instead of landing `config.toml` now and updating it to `boostrap.toml` later. `@rustbot` blocked rust-lang#137081
…rmit, r=tgross35 Implement `read_buf` for Hermit Following hermit-os/kernel#1606, it is now safe to implement `Read::read_buf` for file descriptors on Hermit. cc ```@mkroening```
…laumeGomez rustdoc-json: Add tests for `#[repr(...)]` Works towards rust-lang#137645 and rust-lang#81359 Based on rust-lang#138018, but with only the test changes. CC ```@obi1kenobi``` r? ```@GuillaumeGomez```
…ler-errors Extract `for_each_immediate_subpat` from THIR pattern visitors This is extracted from some larger changes I've been working on, trying to introduce a “THIR pattern id” to refer to THIR pattern nodes without a direct reference. The future of those changes is somewhat uncertain, due to some [proposed changes involving upvar inference](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/upvar.20inference.20on.20THIR.3F). So I'm taking my preparatory changes that make sense on their own, and extracting them into one or more independent PRs. --- This particular patch takes two different functions that were both matching on `PatKind` to traverse subpatterns, and extracts the core match into a single helper function.
Unvacation myself Feeling better now. r? ghost
…rcote Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute` `Transition` is only used in the `Transitions::insert` in test after rust-lang#137776 Detected by rust-lang#128637
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#136320 (exit: document interaction with C) - rust-lang#138080 (Leave a breadcrumb towards bootstrap config documentation in `bootstrap.toml`) - rust-lang#138301 (Implement `read_buf` for Hermit) - rust-lang#138569 (rustdoc-json: Add tests for `#[repr(...)]`) - rust-lang#138635 (Extract `for_each_immediate_subpat` from THIR pattern visitors) - rust-lang#138642 (Unvacation myself) - rust-lang#138644 (Add `#[cfg(test)]` for Transition in dfa in `rustc_transmute`) r? `@ghost` `@rustbot` modify labels: rollup
|
@rustbot ping fuchsia The Fuchsia job seems to be broken (#138653 (comment)), could you please take a look? Thanks! |
|
Hey friends of Fuchsia! This issue could use some guidance on how this should be |
This was referenced Mar 18, 2025
|
This looks very similar to #138661 (comment) but with a different git submodule missing files. jiri reporting local directories with changes: one of which is missing files: |
|
I put together #138683 to see if caching the checkouts avoids the googlesource.com rate limits. |
This was referenced Mar 19, 2025
|
Issue for tracking the Fuchsia problem: #138691 |
This was referenced Mar 19, 2025
|
@bors p=101 |
This was referenced Mar 19, 2025
|
☀️ Test successful - checks-actions |
|
This is an experimental post-merge analysis report. You can ignore it. Post-merge reportWhat is this?This is an experimental post-merge analysis report that shows differences in Comparing 1370611 (parent) -> c4b38a5 (this PR) Test differencesShow 24 test diffs
Additionally, 12 doctest diffs were found. These are ignored, as they are noisy. Job group index
|
|
@bors treeclosed- |
|
Finished benchmarking commit (c4b38a5): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 775.384s -> 776.901s (0.20%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
bootstrap.toml#138080 (Leave a breadcrumb towards bootstrap config documentation inbootstrap.toml)read_buffor Hermit #138301 (Implementread_buffor Hermit)#[repr(...)]#138569 (rustdoc-json: Add tests for#[repr(...)])for_each_immediate_subpatfrom THIR pattern visitors #138635 (Extractfor_each_immediate_subpatfrom THIR pattern visitors)#[cfg(test)]for Transition in dfa inrustc_transmute#138644 (Add#[cfg(test)]for Transition in dfa inrustc_transmute)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup