Various codegen_llvm cleanups #138674
Merged
Various codegen_llvm cleanups #138674
+206
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
S-waiting-on-review
|
@bors r=compiler-errors |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2025
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#136177 (clarify BufRead::{fill_buf, consume} docs) - rust-lang#138654 (Remove the regex dependency from coretests) - rust-lang#138655 (rustc-dev-guide sync) - rust-lang#138656 (Remove double nesting in post-merge workflow) - rust-lang#138658 (CI: mirror alpine and centos images to ghcr) - rust-lang#138659 (coverage: Don't store a body span in `FunctionCoverageInfo`) - rust-lang#138661 (Revert: Add *_value methods to proc_macro lib) - rust-lang#138670 (Remove existing AFIDT implementation) - rust-lang#138674 (Various codegen_llvm cleanups) - rust-lang#138684 (use then in docs for `fuse` to enhance readability) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 19, 2025
Rollup merge of rust-lang#138674 - oli-obk:llvm-cleanups, r=compiler-errors Various codegen_llvm cleanups Mostly just adding safe wrappers and deduplicating code
oli-obk
commented
Mar 20, 2025
| let actual_type_di_node = type_di_node(cx, actual_type); | ||
| Some(cx.create_template_type_parameter(name.as_str(), actual_type_di_node)) | ||
| }) | ||
| let generics = cx.tcx.generics_of(def.did()); |
There was a problem hiding this comment.
This generics_of is now called unconditionally and is likely the source of the perf regression
There was a problem hiding this comment.
Turns out that wasn't it
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2025
Guard a query invocation out of perf reasons Should fix the perf regression from rust-lang#138674
oli-obk
commented
Mar 20, 2025
| work_dir.len(), | ||
| &name_in_debuginfo, | ||
| &work_dir, | ||
| "", | ||
| llvm::ChecksumKind::None, |
There was a problem hiding this comment.
Maybe this. Empty string now, null pointer before
There was a problem hiding this comment.
But that wouldn't explain the query count changes
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2025
Avoid sending a non-null pointer for empty strings Another try at fixing the perf regression from rust-lang#138674 r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just adding safe wrappers and deduplicating code