Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the regex dependency from coretests #138654

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Remove the regex dependency from coretests #138654

merged 1 commit into from
Mar 19, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Mar 18, 2025

It is only used by a single test, yet would take up unnecessary space once stdlib deps get vendored.

@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2025

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

tgross35
tgross35 approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once the test passes in CI. Optional nit, the arg names for check_fmt could be start and contains or similar rather than expected1 and expected2.

once stdlib deps get vendored.

What is this referring to?

@tgross35 tgross35 assigned tgross35 and unassigned Mark-Simulacrum Mar 18, 2025
@bjorn3
Copy link
Member Author

bjorn3 commented Mar 18, 2025

once stdlib deps get vendored.

What is this referring to?

For -Zbuild-std we will probably have to start vendoring all standard library dependencies into the rust-src component at some point to be able to do offline -Zbuild-std builds: rust-lang/wg-cargo-std-aware#23 (comment)

@bjorn3
Remove the regex dependency from coretests
7f4d3bd 
It is only used by a single test, yet would take up unnecessary space
once stdlib deps get vendored.
@bjorn3 bjorn3 force-pushed the remove_coretests_regex branch from 7cf430a to 7f4d3bd Compare March 18, 2025 09:34
@tgross35
Copy link
Contributor

Makes sense. It would be nice if we could somehow split test dependencies to a separate Cargo.lock, this is confusing for licenses and e.g. rand's changing requirements.

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 18, 2025

Yeah, would make sense to do in the future I guess. Probably doesn't make much sense yet until all standard library tests have been split into separate packages though.

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 18, 2025

@bors r=tgross35

@bors
Copy link
Contributor

bors commented Mar 18, 2025

📌 Commit 7f4d3bd has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 19, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2025
@bors
Auto merge of rust-lang#138693 - matthiaskrgr:rollup-ejq8mwp, r=matth…
a7fc463 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#136177 (clarify BufRead::{fill_buf, consume} docs)
 - rust-lang#138654 (Remove the regex dependency from coretests)
 - rust-lang#138655 (rustc-dev-guide sync)
 - rust-lang#138656 (Remove double nesting in post-merge workflow)
 - rust-lang#138658 (CI: mirror alpine and centos images to ghcr)
 - rust-lang#138659 (coverage: Don't store a body span in `FunctionCoverageInfo`)
 - rust-lang#138661 (Revert: Add *_value methods to proc_macro lib)
 - rust-lang#138670 (Remove existing AFIDT implementation)
 - rust-lang#138674 (Various codegen_llvm cleanups)
 - rust-lang#138684 (use then in docs for `fuse` to enhance readability)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a4c32b1 into rust-lang:master Mar 19, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 19, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2025
@rust-timer
Unrolled build for rust-lang#138654
065ba27 
Rollup merge of rust-lang#138654 - bjorn3:remove_coretests_regex, r=tgross35

Remove the regex dependency from coretests

It is only used by a single test, yet would take up unnecessary space once stdlib deps get vendored.
@bjorn3 bjorn3 deleted the remove_coretests_regex branch March 19, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35

Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rustbot @tgross35 @bors @Mark-Simulacrum