-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CI LLVM checks in bootstrap #138704
Conversation
This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp. This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
Uhh, crap, this breaks the |
This comment has been minimized.
This comment has been minimized.
Hmm, a lot of bootstrap tests parse flags to create a config, and the default value for |
"if-unchanged" syncs llvm submodule, that's why |
c349e6b
to
59c3417
Compare
This comment has been minimized.
This comment has been minimized.
Before it was using a different set of paths in different call-sites.
…ci-llvm=true` on CI
To avoid working around some code being unused in tests due to it being stubbed out with `#[cfg(test)]`.
Changes look good but this is one of those PRs where it's hard to find issues without merging it... So let's try that now. @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a4a11ac): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary 3.7%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 775.474s -> 775.351s (-0.02%) |
Extracted out of #138591. Apart from simplifying the checks, it will make it easier to run E2E tests of bootstrap on a mostly empty directory without checking out LLVM on CI :)
The commits should be mostly self-explanatory.
r? @onur-ozkan