Bump boostrap cc to 1.2.17 and cmake to 0.1.54
#138784
Open
+44
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Please add |
madsmtm
force-pushed
the
bootstrap-bump-cc-cmake
branch
from
85502fc to
673b519
Compare
|
Ah, that's why, I really couldn't understand why it didn't work (and failing in Have added to |
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2025
…try> Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) for exact details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
|
@bors delegate+ (for try-jobs only, I haven't looked at the cc diff) |
madsmtm
force-pushed
the
bootstrap-bump-cc-cmake
branch
from
ce6caef to
c93efd1
Compare
|
Okay so the failure comes from all the way back in rust-lang/cmake-rs#158, see also rust-lang/cmake-rs#228. I've added a workaround in bootstrap, though ideally this should be fixed in @bors try |
madsmtm
force-pushed
the
bootstrap-bump-cc-cmake
branch
from
c93efd1 to
061eda1
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2025
Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) for exact details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
To avoid a panic in cmake-rs that was introduced in: rust-lang/cmake-rs#158
compiler-rt's CMake setup seems to have special logic for Apple platforms that works poorly when this is not set.
Similarly to what was previously done for the `llvm` step.
madsmtm
force-pushed
the
bootstrap-bump-cc-cmake
branch
from
da19f9e to
1f675d3
Compare
|
Gonna try a hunch with @bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 24, 2025
…try> Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the `cc-rs` changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) and [the `cmake-rs` changelog](https://github.com/rust-lang/cmake-rs/blob/fd56c5a6b4ecda8815c863eb5b12d7b3f0391197/CHANGELOG.md) for details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: dist-apple-various
|
☀️ Try build successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2025
…try> Bump boostrap `cc` to 1.2.17 and `cmake` to 0.1.54 The `cc` version in `bootstrap` was reverted down to 1.1.22 in rust-lang#137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version of `cc` has been released in rust-lang/cc-rs#1435, so let's try to update the version again. See [the `cc-rs` changelog](https://github.com/rust-lang/cc-rs/blob/d9dd20e376368c7535f6ef89b809098f5f203c1a/CHANGELOG.md) and [the `cmake-rs` changelog](https://github.com/rust-lang/cmake-rs/blob/fd56c5a6b4ecda8815c863eb5b12d7b3f0391197/CHANGELOG.md) for details on what has changed here. r? jieyouxu who tried this last in rust-lang#137022. `@rustbot` label T-bootstrap try-job: *apple*
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
rustbot
added
S-waiting-on-review
|
Unsure about |
|
☀️ Try build successful - checks-actions |
|
Messing with CMake can likely change how LLVM is built, so I would bump the stamp file. |
This PR makes a fairly large version update to CMake and cc, so it is likely that LLVM is built differently.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Hmm, seems like it failed while testing Failure: |
|
Hmm. Looking at the test, I think that it doesn't really make sense anymore after #138704. |
Should wait few days for pr, maybe it will be merged? |
I'd rather file a follow-up later, it can take time for a new
Do you think I should remove it, then? |
I will do it in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ccversion inbootstrapwas reverted down to 1.1.22 in #137460 (previously at 1.2.0). The offending issue has since then been resolved in rust-lang/cc-rs#1413, and a new version ofcchas been released in rust-lang/cc-rs#1435, so let's try to update the version again.See the
cc-rschangelog and thecmake-rschangelog for details on what has changed here.r? jieyouxu who tried this last in #137022.
@rustbot label T-bootstrap
try-job: apple