Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carousel caption heading colors #37797

Closed
wants to merge 1 commit into from

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 3, 2023

Description

This PR suggests to set --bs-heading-color to black in dark mode or when .carousel-dark is used.
TBH I'm not a big fan of this modification so far but headers have a color set by --bs-heading-color which has a bigger priority compared to .carousel-caption color. So I haven't found a more elegant way of doing it for now. Thoughts to improve this PR?

Motivation & Context

Color consistency between header and text colors within .carousel-caption.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Please check the following URLs in light and dark modes:

Related issues

Closes #37795

@julien-deramond julien-deramond marked this pull request as ready for review January 3, 2023 16:43
@julien-deramond julien-deramond requested a review from a team as a code owner January 3, 2023 16:43
@mdo
Copy link
Member

mdo commented Jan 3, 2023

I think I just have to remove the heading color from dark mode. Causing too many issues it seems.

@julien-deramond
Copy link
Member Author

Yep seems to be an issue in #37799 as well.
Let's try to evaluate if it's doable without this heading color. If we go for it, this PR can be closed.

@mdo mdo closed this in #37800 Jan 4, 2023
@XhmikosR XhmikosR deleted the main-jd-fix-carousel-captions-heading branch March 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Carousel caption color in dark mode
2 participants