Fix carousel caption heading colors #37797
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests to set
--bs-heading-color
to black in dark mode or when.carousel-dark
is used.TBH I'm not a big fan of this modification so far but headers have a color set by
--bs-heading-color
which has a bigger priority compared to.carousel-caption
color. So I haven't found a more elegant way of doing it for now. Thoughts to improve this PR?Motivation & Context
Color consistency between header and text colors within
.carousel-caption
.Type of changes
Checklist
npm run lint
)Live previews
Please check the following URLs in light and dark modes:
Related issues
Closes #37795