Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heading colors in dark mode #37800

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix heading colors in dark mode #37800

merged 1 commit into from
Jan 4, 2023

Conversation

mdo
Copy link
Member

@mdo mdo commented Jan 4, 2023

  • Removes dark mode --bs-heading-color value
  • Set the $headings-color-dark Sass variable to null and add a null check to the root variable
  • Adds custom styles for the docs dark mode headings

Closes #37797, fixes #37799, fixes #37795.

@mdo mdo requested a review from a team as a code owner January 4, 2023 03:31
@mdo mdo merged commit da1c968 into main Jan 4, 2023
@mdo mdo deleted the darkmode-heading-color branch January 4, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
color mode css v5
Projects
No open projects
v5.3.0-alpha2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nesting color mode: colors of headers are not overwritten [Docs] Carousel caption color in dark mode
1 participant
@mdo