LanguageAndLexicalCategoryWidget Vue Test and Prod Template are not in sync
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Tarrow
	Dec 13 2018, 10:41 AM

Description

Due to T198455 the versions on the templates in tests/jasmine/LanguageAndLexicalCategoryWidget.spec.js and LexemeView.php have become out of sync.

Specifically the spec currently includes a native html <input> whereas the production version includes a <item-selector> component.

It is not possible to put them back in sync without causing the jasmine tests to fail. This can be seen in the following PS: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/479183

The tests fail with the widget appearing to be populated by: NaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaNNaN....

This bug was found while working on: T209931 and I suspect due to the fact the entityselector widget from wikibase is not available in the jasmine test environment.

Details

	Subject	Repo	Branch	Lines +/-
	Sync LanguageAndLexicalCategoryWidget production and test template	mediawiki/extensions/WikibaseLexeme	master	+247 -19

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T211866 LanguageAndLexicalCategoryWidget Vue Test and Prod Template are not in sync
		Declined		None	T211867 Lexeme jasmine tests should include upstream wikibase dependencies

Event Timeline

Tarrow created this task.Dec 13 2018, 10:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2018, 10:41 AM

Addshore moved this task from incoming to consider for next sprint on the Wikidata board.Dec 14 2018, 10:28 AM

Addshore added a project: Wikidata-Trailblazing-Exploration.Jun 22 2019, 10:52 PM

Addshore removed a project: Wikidata-Campsite.Nov 19 2019, 3:09 PM

@Jakob_WMDE says that this might be solvable with something new in reosurceloader now. Pinging him to populate this in trailblaze investigation and then we can look at this again soon.

Change 554488 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Sync LanguageAndLexicalCategoryWidget production and test template

https://gerrit.wikimedia.org/r/554488

gerritbot added a project: Patch-For-Review.Dec 4 2019, 11:22 AM

In T211866#5709233, @Addshore wrote:

@Jakob_WMDE says that this might be solvable with something new in reosurceloader now. Pinging him to populate this in trailblaze investigation and then we can look at this again soon.

I obviously didn't read the task description properly when I claimed that, and confused this task with T198455. I still looked into it for a moment, and while I agree that not being able to easily include entityselector in the test, we can work around this in this case by stubbing child components using @vue/test-utils. Here's an almost ok looking patch that does this: https://gerrit.wikimedia.org/r/554488

Addshore moved this task from consider for next sprint to in progress on the Wikidata board.Dec 11 2019, 11:59 AM

Addshore closed subtask T211867: Lexeme jasmine tests should include upstream wikibase dependencies as Declined.Jan 16 2020, 11:26 PM

Addshore triaged this task as Low priority.Jan 29 2020, 11:27 AM

Addshore moved this task from In Investigation (cost/impact) to Campsite Candidates on the Wikidata-Trailblazing-Exploration board.

Addshore added a project: Wikidata-Campsite.

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.

Addshore removed Jakob_WMDE as the assignee of this task.Jul 17 2020, 10:05 AM

Since T198455 the templates are in sync, so I think this can be closed. We stumbled upon this task again while working on T266936.

Change 554488 abandoned by Lucas Werkmeister (WMDE):
[mediawiki/extensions/WikibaseLexeme@master] Sync LanguageAndLexicalCategoryWidget production and test template

Reason:
This was eventually done in T198455. (I’m mainly abandoning this change so it stops showing up as “conflicts with” in other changes that happen to touch the same files, such as I7cd23af9bd.)