Page MenuHomePhabricator

Update Labels and Placeholders for Special:NewLexeme inputs
Closed, ResolvedPublic2 Estimated Story Points

Description

In the context of the new NewLexeme special page we're going to create a lot of new messages. However, we discussed that we want to reuse the ones for the Input labels and placeholders and just replace the current copy. It is acceptable that this also changes the copy on the existing legacy NewLexeme special page.

Acceptance criteria:

Messages:

Current message on the new pageProposed new message
placeholder for LemmaShort form of a word, e.g. 'first'Base form of a word, e.g. 'speak'
placeholder for languageThe Lexeme's language, e.g. 'English'<no change>
placeholder for spelling variantLanguage code for the Lemma's spelling variant, e.g., 'en'Language code for the Lemma's spelling variant, e.g. 'en'
placeholder for lexical categoryThe Lexeme's category, e.g. 'numeral'The Lexeme's lexical category, e.g. 'verb'
example LexemeL2 (first)L380 (speak)

Notes:

  • The placeholder messages for lexical category and language are discussed in T307443, we anticipate that we would need to create new translation messages for these placeholders, and that we would get rid of the old messages, once the Special:NewLexeme page is replaced.

Event Timeline

Lydia_Pintscher removed a project: Epic.

@Erdinc_Ciftci_WMDE This needs you. What should the final copy for the Lemma placeholder be?

karapayneWMDE set the point value for this task to 2.Mar 9 2022, 1:39 PM

Here are the specs with an updated copy for Lemma placeholder, if there is anything else needed from design I can happily provide it @Michael

Screenshot 2022-03-09 at 15.13.07.png (332×564 px, 83 KB)

Here are the specs with an updated copy for Lemma placeholder, if there is anything else needed from design I can happily provide it @Michael

Screenshot 2022-03-09 at 15.13.07.png (332×564 px, 83 KB)

Cool, I think this is ready to be picked up in the next sprint then!

I already had a patch starting this from Sprint 1 or something, so I might as well finish it.

Change 763720 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Add the message keys we're using to ResourceLoader

https://gerrit.wikimedia.org/r/763720

Change 763720 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add the message keys we're using to ResourceLoader

https://gerrit.wikimedia.org/r/763720

Change 773511 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Include new Lookups in Special:NewLexemeAlpha

https://gerrit.wikimedia.org/r/773511

Change 773511 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Include new Lookups in Special:NewLexemeAlpha

https://gerrit.wikimedia.org/r/773511

As this copy also made its way to existing Special:NewLexeme page, there was some feedback from the community via telegram. A summary:

several people are wondering what “short” in “short form of a word, e.g. 'first'” means

someone suggested “base” or “basic” instead, “e.g. 'swim' (rather than 'swimming')”

also some confusion about the “first” – why this was chosen, and whether it should be translated (with some saying numerals aren’t an ideal example lexical category)

and finally, one worry that “the lexeme’s category” might encourage the use of items like “category:english lemmas” as the lexical category

Lydia_Pintscher updated Other Assignee, added: Erdinc_Ciftci_WMDE.

Erdi and I will have a look at the feedback. Thanks, Michael.

Ok based on this feedback I would propose the following message update:

Current message on the new pageProposed new message
placeholder for LemmaShort form of a word, e.g. 'first'Base form of a word, e.g. 'swim' (rather than 'swimming')
placeholder for languageThe Lexeme's language, e.g. 'English'<no change>
placeholder for spelling variantLanguage code for the Lemma's spelling variant, e.g., 'en'Language code for the Lemma's spelling variant, e.g. 'en'
placeholder for lexical categoryThe Lexeme's category, e.g. 'numeral'The Lexeme's lexical category, e.g. 'verb'
example LexemeL2 (first)L344 (swim)

@Nikki @Mahir256 @Erdinc_Ciftci_WMDE Thoughts? Anyone else?

Ok based on this feedback I would propose the following message update:

Current message on the new pageProposed new message
placeholder for LemmaShort form of a word, e.g. 'first'Base form of a word, e.g. 'swim' (rather than 'swimming')
placeholder for languageThe Lexeme's language, e.g. 'English'<no change>
placeholder for spelling variantLanguage code for the Lemma's spelling variant, e.g., 'en'Language code for the Lemma's spelling variant, e.g. 'en'
placeholder for lexical categoryThe Lexeme's category, e.g. 'numeral'The Lexeme's lexical category, e.g. 'verb'
example LexemeL2 (first)L344 (swim)

@Nikki @Mahir256 @Erdinc_Ciftci_WMDE Thoughts? Anyone else?

With the placeholder for the spelling variant - did something change other than a comma being removed?

Overall, I think it makes sense, but keep in mind that there is a tradeoff between clarity and length of the placeholder. Especially on mobile, a long placeholder might not be visible in full.

With the placeholder for the spelling variant - did something change other than a comma being removed?

No just that indeed.

Ok based on this feedback I would propose the following message update:

Current message on the new pageProposed new message
placeholder for LemmaShort form of a word, e.g. 'first'Base form of a word, e.g. 'swim' (rather than 'swimming')
placeholder for languageThe Lexeme's language, e.g. 'English'<no change>
placeholder for spelling variantLanguage code for the Lemma's spelling variant, e.g., 'en'Language code for the Lemma's spelling variant, e.g. 'en'
placeholder for lexical categoryThe Lexeme's category, e.g. 'numeral'The Lexeme's lexical category, e.g. 'verb'
example LexemeL2 (first)L344 (swim)

@Nikki @Mahir256 @Erdinc_Ciftci_WMDE Thoughts? Anyone else?

For some reason this didn't create a notification for me, the other people you pinged might not have got one either.

In general I find the current placeholders odd. Why do they repeat the label for the field? If you don't understand what is meant, repeating it doesn't help.

I definitely prefer using a verb as the example, but maybe a verb more relevant to lexemes like "speak" or "write" would be nicer? :)

"Base form" is far better than "Short form" (which sounds like abbreviation... and the lemma is not necessarily even the shortest form) but I wouldn't include the " (rather than 'swimming')" part. What doesn't belong in there seems like something better suited to documentation than the placeholder field. It would also make it harder for translators since many languages don't have a progressive form.

Thanks, Nikki!

In general I find the current placeholders odd. Why do they repeat the label for the field? If you don't understand what is meant, repeating it doesn't help.

That's something for @Erdinc_Ciftci_WMDE I guess.

New version then:

Current message on the new pageProposed new message
placeholder for LemmaShort form of a word, e.g. 'first'Base form of a word, e.g. 'speak'
placeholder for languageThe Lexeme's language, e.g. 'English'<no change>
placeholder for spelling variantLanguage code for the Lemma's spelling variant, e.g., 'en'Language code for the Lemma's spelling variant, e.g. 'en'
placeholder for lexical categoryThe Lexeme's category, e.g. 'numeral'The Lexeme's lexical category, e.g. 'verb'
example LexemeL2 (first)L380 (speak)
Lydia_Pintscher updated Other Assignee, removed: Erdinc_Ciftci_WMDE.
Lydia_Pintscher moved this task from Backlog to milestone 2 on the Special:NewLexeme revival board.

Change 790404 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Remove comma after e.g.

https://gerrit.wikimedia.org/r/790404

Change 790404 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Remove comma after e.g.

https://gerrit.wikimedia.org/r/790404

Change 792124 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[mediawiki/extensions/WikibaseLexeme@master] Update messages for new lexeme placeholders

https://gerrit.wikimedia.org/r/792124

Change 792124 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update messages for new lexeme placeholders

https://gerrit.wikimedia.org/r/792124

Change 792214 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use placeholders with example data in JS Special:NewLexemeAlpha

https://gerrit.wikimedia.org/r/792214

Change 792214 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use placeholders with example data in JS Special:NewLexemeAlpha

https://gerrit.wikimedia.org/r/792214