Change 920804 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add participant question on registering

https://gerrit.wikimedia.org/r/920804

Change 920804 abandoned by Cmelo:

[mediawiki/extensions/CampaignEvents@master] Add participant question on registering

Reason:

https://gerrit.wikimedia.org/r/920804

Change 920807 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add participant question when registering 2

https://gerrit.wikimedia.org/r/920807

For the MVP I remember we said that organizers will not be able to choose what question they want to ask in their events, instead we will always ask all questions.
@Daimona did it change because of legal requirements when I was OOO?

In T335809#8902419, @cmelo wrote:

For the MVP I remember we said that organizers will not be able to choose what question they want to ask in their events, instead we will always ask all questions.
@Daimona did it change because of legal requirements when I was OOO?

No, it didn't change, nor did I change it in my edit. It seems like the AC of this task simply weren't updated with that decision.

In T335809#8902443, @Daimona wrote:

In T335809#8902419, @cmelo wrote:

For the MVP I remember we said that organizers will not be able to choose what question they want to ask in their events, instead we will always ask all questions.
@Daimona did it change because of legal requirements when I was OOO?

No, it didn't change, nor did I change it in my edit. It seems like the AC of this task simply weren't updated with that decision.

Oh, I see, thank you!

Change 935148 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add header to visibility fieldset in event pages

https://gerrit.wikimedia.org/r/935148

Change 935148 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add header to visibility fieldset in event pages

https://gerrit.wikimedia.org/r/935148

Change 920807 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add participant question to the registration dialog

https://gerrit.wikimedia.org/r/920807

Change 937062 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add participant answers data to the payload of the request to register for an event

https://gerrit.wikimedia.org/r/937062

Upon reading the AC again:

Participants understand that they are able to edit their answers after they have registered (via messaging in the UI).

The current implementation uses "All questions are optional" for the subtitle, which is what's in the prototype linked in the task description ("latest design"). The screenshot in T336853 has another version ("You can change or remove your responses..."). And the V2 prototypes have yet another version that mentions the 90 days constrain. I'm unsure how we want to proceed here. @cmelo @MHorsey-WMF @gonyeahialam

In T335809#9009569, @Daimona wrote:

Upon reading the AC again:

Participants understand that they are able to edit their answers after they have registered (via messaging in the UI).

The current implementation uses "All questions are optional" for the subtitle, which is what's in the prototype linked in the task description ("latest design"). The screenshot in T336853 has another version ("You can change or remove your responses..."). And the V2 prototypes have yet another version that mentions the 90 days constrain. I'm unsure how we want to proceed here. @cmelo @MHorsey-WMF @gonyeahialam

All questions listed in T321822, are optional for participants to answer (legal requirement).

For this AC, the final decision was to have the optional added to the question label and remove it from subtitle

Participants understand that they are able to edit their answers after they have registered (via messaging in the UI).

For V2 PII, this information has been added to the data retention section at the end of the form.
I will update the task description

In T335809#9011765, @gonyeahialam wrote:

For V2 PII, this information has been added to the data retention section at the end of the form.
I will update the task description

Thanks!

Change 938350 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Update subtitle of the registration dialog

https://gerrit.wikimedia.org/r/938350

@gonyeahialam I don't see the "clear form" button in the latest prototype. Is this intentional, and does this mean that we don't need to add it?

In T335809#9017154, @Daimona wrote:

@gonyeahialam I don't see the "clear form" button in the latest prototype. Is this intentional, and does this mean that we don't need to add it?

The button is in the prototype, you see it when you click on edit registration. It is also in the design file

In T335809#9020797, @gonyeahialam wrote:

In T335809#9017154, @Daimona wrote:

@gonyeahialam I don't see the "clear form" button in the latest prototype. Is this intentional, and does this mean that we don't need to add it?

The button is in the prototype, you see it when you click on edit registration. It is also in the design file

Ah, thanks. The spec you linked is not the same as that in the task description, that's why I was confused.

Change 938947 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add button to clear form when registering for event

https://gerrit.wikimedia.org/r/938947

Change 938350 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Update subtitle of the registration dialog

https://gerrit.wikimedia.org/r/938350

Change 938947 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add button to clear form when registering for event

https://gerrit.wikimedia.org/r/938947

[] All questions listed in T321822, are optional for participants to answer (legal requirement).
✅ Participants can populate form fields with their answers when registering for an event.
✅ Participants understand that the information is only shared with the organisers via a subtitle in the form. Note: unlike the prototype, the implementation should use American English, so it would be "organizers" instead of "organisers" and "will" instead of "would".
[] Participants can click a button to clear the form

🔴 All questions listed in T321822, are optional for participants to answer (legal requirement).

As noted in a few other tickets (and I know everyone is already aware of this, but since it is in the AC I am mentioning it here), the participant questions and some of the copy is not yet up to date with the specs at T321822, and I am not even sure that those questions and potential answers are finalized yet.

🔴 Participants can click a button to clear the form

I would expect clicking Clear form to reset all values of the form to the default but the Clear form button does not reset Public registration to true. Is this intentional? All of the rest of the form does correctly clear except for Public registration

🔴 One CSS thing to note:

The register button should take up the whole height of the containing div.
Example on Chrome:

In T335809#9039168, @vaughnwalters wrote:

🔴 All questions listed in T321822, are optional for participants to answer (legal requirement).

As noted in a few other tickets (and I know everyone is already aware of this, but since it is in the AC I am mentioning it here), the participant questions and some of the copy is not yet up to date with the specs at T321822, and I am not even sure that those questions and potential answers are finalized yet.

Indeed. I don't know if those options are final, but we're updating them in T342341.

🔴 Participants can click a button to clear the form

I would expect clicking Clear form to reset all values of the form to the default but the Clear form button does not reset Public registration to true. Is this intentional? All of the rest of the form does correctly clear except for Public registration

Good point. It is sort of intentional, but I'm not sure if it's the intended behaviour. @gonyeahialam do you have an answer to this?

🔴 One CSS thing to note:

The register button should take up the whole height of the containing div.

Weird, it is full height for me on both Chrome and Firefox. But at any rate, we're not applying any special styles to it, so this would be a bug in OOUI.

In T335809#9039583, @Daimona wrote:

In T335809#9039168, @vaughnwalters wrote:

🔴 Participants can click a button to clear the form

I would expect clicking Clear form to reset all values of the form to the default but the Clear form button does not reset Public registration to true. Is this intentional? All of the rest of the form does correctly clear except for Public registration

Good point. It is sort of intentional, but I'm not sure if it's the intended behaviour. @gonyeahialam do you have an answer to this?

Yeah. The clear form doesn't affect the Registration privacy.

Remaining acceptance criteria:

✅ All questions listed in T321822, are optional for participants to answer (legal requirement).

• All questions are optional, and this wording will be finalized in T342341, so marking this AC as done.

✅ Participants can click a button to clear the form

• Since the clear form is not meant to change the Registration privacy, this is working as intended.

Moving this to design sign off.