Page MenuHomePhabricator
Create Task
Maniphest T339257

API backend for participant questions
Closed, ResolvedPublic
Actions

Assigned To
Daimona
Authored By
MHorsey-WMF
Jun 15 2023, 3:49 PM
Tags
Referenced Files
F37140706: Screenshot 2023-07-16 at 12.34.07 PM.png
Jul 16 2023, 5:36 PM
F37136154: Screenshot 2023-07-11 at 10.51.42 AM.png
Jul 11 2023, 9:32 PM
F37136151: Screen Recording 2023-07-11 at 11.43.13 AM.gif
Jul 11 2023, 9:32 PM
F37136360: Screenshot 2023-07-11 at 4.31.43 PM.png
Jul 11 2023, 9:32 PM
F37136143: Screen Recording 2023-07-11 at 11.35.44 AM.gif
Jul 11 2023, 9:32 PM
F37136135: Screenshot 2023-07-11 at 11.31.03 AM.png
Jul 11 2023, 9:32 PM
Subscribers
Aklapper
Daimona
MHorsey-WMF
vaughnwalters

Description

Acceptance criteria
  • As a user
    • Given I have registered
    • And I have answered participant questions for the first time
    • Those answers should be submitted to an API to be saved
  • As a user
    • Given I have registered
    • And I have answered participant questions
    • And I have edited their answers
    • Those answers should be submitted to an API to be updated
  • As a user
    • Given I have registered
    • And I have answered participant questions
    • And I have revoked my registration
    • My answers should be submitted to an API to be deleted
  • The "register for event" endpoint documentation should be documented
Other dependencies
  • The ability to edit answers is dependent on T336853. If this task is resolved before that one, then the requirement for editing is that internally, the answers you gave when registering are left untouched.
  • The internal backend will be developed in T339259, and it can then be used here

Details

SubjectRepoBranchLines +/-
Update error message when GETting registration info if user is not globalmediawiki/extensions/CampaignEventsmaster+4 -4
Add support for participant questions to the APImediawiki/extensions/CampaignEventsmaster+254 -24
Create backend for storing participant answersmediawiki/extensions/CampaignEventsmaster+569 -31
Customize query in gerrit

Related Objects
Search...

Event Timeline

MHorsey-WMF created this task.Jun 15 2023, 3:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2023, 3:49 PM
Daimona added a project: CampaignEvents.Jun 16 2023, 2:31 PM
MHorsey-WMF added a parent task: T321822: [EPIC] Participant Questions - MVP.Jun 22 2023, 1:19 PM
MHorsey-WMF merged a task: T339987: Delete participant answers and date of first answer when they unregister.Jun 22 2023, 1:26 PM
MHorsey-WMF updated the task description. (Show Details)
MHorsey-WMF moved this task from Upcoming / refining 💡 to Ready for development on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
MHorsey-WMF added a subscriber: Daimona.
Daimona mentioned this in T336857: [IMPLEMENTATION] Back end: create the database layers for the tables: ce_question_answers, ce_question_aggregation,ce_event_questions.Jun 23 2023, 12:32 PM
Daimona updated the task description. (Show Details)
gerritbot added a comment.Jun 23 2023, 5:49 PM

Change 932448 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Create backend for storing participant answers

https://gerrit.wikimedia.org/r/932448

gerritbot added a project: Patch-For-Review.Jun 23 2023, 5:49 PM
Daimona updated the task description. (Show Details)Jun 23 2023, 5:56 PM
Daimona added a subtask: T339259: form backend for participant questions.Jun 26 2023, 4:18 PM
Daimona updated the task description. (Show Details)
Daimona claimed this task.Jun 29 2023, 11:42 AM
Daimona moved this task from Ready for development to Development In Progress 💻 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
Daimona added a subtask: T340736: Provide available and current participant questions via the API.Jun 29 2023, 11:57 AM
Daimona updated the task description. (Show Details)Jun 30 2023, 12:17 AM
gerritbot added a comment.Jun 30 2023, 7:39 PM

Change 932448 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Create backend for storing participant answers

https://gerrit.wikimedia.org/r/932448

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 30 2023, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 30 2023, 8:10 PM
gerritbot added a comment.Jul 3 2023, 1:37 PM

Change 934426 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Add support for participant questions to the API

https://gerrit.wikimedia.org/r/934426

gerritbot added a project: Patch-For-Review.Jul 3 2023, 1:37 PM
Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 3 2023, 1:37 PM
Daimona mentioned this in T336853: [IMPLEMENTATION] Front end: (JS experience), Allow participants to answer questions on the event page.Jul 11 2023, 2:13 PM
gerritbot added a comment.Jul 11 2023, 2:21 PM

Change 934426 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add support for participant questions to the API

https://gerrit.wikimedia.org/r/934426

Daimona moved this task from Code Review 💬 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 11 2023, 2:30 PM
Daimona removed a project: Patch-For-Review.

Documentation updated.

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 11 2023, 3:00 PM
vaughnwalters subscribed.EditedJul 11 2023, 9:32 PM

As a user
Given I have registered
And I have answered participant questions for the first time
✅ Those answers should be submitted to an API to be saved

Screenshot 2023-07-11 at 11.31.03 AM.png (1×1 px, 257 KB)

and those answers are correctly reflected in the GUI as well.

As a user
Given I have registered
And I have answered participant questions
And I have edited their answers
✅ Those answers should be submitted to an API to be updated

Screen Recording 2023-07-11 at 11.35.44 AM.gif (2×3 px, 1 MB)

Also correctly updates the affiliate free text field.

Screenshot 2023-07-11 at 4.31.43 PM.png (1×2 px, 630 KB)

Given I have registered
And I have answered participant questions
And I have revoked my registration
✅ My answers should be submitted to an API to be deleted

Screen Recording 2023-07-11 at 11.43.13 AM.gif (2×3 px, 891 KB)

This ticket looks good. @Daimona , can we change the error message "You need a central user account in order to register for events." to You are not allowed to register for events if the user is not logged in but attempts to register though?

Screenshot 2023-07-11 at 10.51.42 AM.png (1×1 px, 199 KB)

gerritbot added a comment.Jul 11 2023, 11:13 PM

Change 937191 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Update error message when GETting questions if user is not global

https://gerrit.wikimedia.org/r/937191

gerritbot added a project: Patch-For-Review.Jul 11 2023, 11:13 PM
Daimona moved this task from QA 🐛 to Code Review 💬 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 11 2023, 11:13 PM
gerritbot added a comment.Jul 14 2023, 8:50 AM

Change 937191 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Update error message when GETting registration info if user is not global

https://gerrit.wikimedia.org/r/937191

Maintenance_bot removed a project: Patch-For-Review.Jul 14 2023, 9:11 AM
Daimona moved this task from Code Review 💬 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 14 2023, 12:13 PM

Error message updated.

ifried closed subtask T339259: form backend for participant questions as Resolved.Jul 14 2023, 7:21 PM
ifried closed subtask T340736: Provide available and current participant questions via the API as Resolved.Jul 14 2023, 7:48 PM
vaughnwalters moved this task from QA 🐛 to Product sign-off 🖌️ on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 16 2023, 5:36 PM
In T339257#9015232, @Daimona wrote:

Error message updated.

✅ Error message successfully updated in case of user logged out user attempting to register for an event.

Screenshot 2023-07-16 at 12.34.07 PM.png (1×1 px, 211 KB)

all AC met in T339257#9007064, moving this to product sign off.

ifried closed this task as Resolved.Jul 21 2023, 5:58 PM
ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits