Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to LLVM dropping CfiFunctionIndex::begin()/end() #138420

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

zmodem
Copy link
Contributor

@zmodem zmodem commented Mar 12, 2025

After llvm/llvm-project#130382, RustWrapper needs to call CfiFunctionIndex::symbols() instead.

After llvm/llvm-project#130382, RustWrapper
needs to call CfiFunctionIndex::symbols() instead.
@rustbot
Copy link
Collaborator

rustbot commented Mar 12, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2025
@zmodem
Copy link
Contributor Author

zmodem commented Mar 12, 2025

@rustbot label llvm-main
r? @durin42

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Mar 12, 2025
@rustbot rustbot assigned durin42 and unassigned cuviper Mar 12, 2025
@durin42
Copy link
Contributor

durin42 commented Mar 12, 2025

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Mar 12, 2025

📌 Commit eb2e421 has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138126 (Add an opt-out in pretty printing for RTN rendering)
 - rust-lang#138399 (Delegation: allow foreign fns `reuse`)
 - rust-lang#138406 (Update mdbook to 0.4.47)
 - rust-lang#138417 (minor interpreter cleanups)
 - rust-lang#138420 (Adapt to LLVM dropping CfiFunctionIndex::begin()/end())
 - rust-lang#138423 (Don't emit error within cast function, propagate it as a `CastError`)
 - rust-lang#138425 (Remove `feature = "hash_raw_entry"`)
 - rust-lang#138427 (Fix RISC-V VxWorks LLVM target triples)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4c20fe8 into rust-lang:master Mar 13, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 13, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 13, 2025
Rollup merge of rust-lang#138420 - zmodem:cfifunctionindex_fix, r=durin42

Adapt to LLVM dropping CfiFunctionIndex::begin()/end()

After llvm/llvm-project#130382, RustWrapper needs to call CfiFunctionIndex::symbols() instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants