Fix RISC-V VxWorks LLVM target triples #138427
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The targets used the plain `$ARCH` triple, which LLVM normalizes to `$ARCH-unknown-unknown`, which is inconsistent with the the other VxWorks targets which all use `$ARCH-unknown-linux-gnu$ABI`.
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
|
Same here, r=me if the target maintainer is on board with the change. |
|
@rustbot blocked (waiting to hear back from target maintainers, not much for me or PR author to do) |
rustbot
added
S-blocked
|
The target triple passed to compilers in vxworks is riscv32 and riscv64, but with numerous flags. I'll test the changes and let you know if unknown linux gnu target is compatible for these targets. |
rustbot
added
S-waiting-on-review
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 13, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#138126 (Add an opt-out in pretty printing for RTN rendering) - rust-lang#138399 (Delegation: allow foreign fns `reuse`) - rust-lang#138406 (Update mdbook to 0.4.47) - rust-lang#138417 (minor interpreter cleanups) - rust-lang#138420 (Adapt to LLVM dropping CfiFunctionIndex::begin()/end()) - rust-lang#138423 (Don't emit error within cast function, propagate it as a `CastError`) - rust-lang#138425 (Remove `feature = "hash_raw_entry"`) - rust-lang#138427 (Fix RISC-V VxWorks LLVM target triples) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 13, 2025
Rollup merge of rust-lang#138427 - madsmtm:vxworks-llvm-target, r=jieyouxu Fix RISC-V VxWorks LLVM target triples The targets `riscv32-wrs-vxworks` and `riscv64-wrs-vxworks` uses the plain `$ARCH` LLVM triple, which LLVM normalizes to `$ARCH-unknown-unknown`, we should use `$ARCH-unknown-linux-gnu$ABI` which is consistent with the the other VxWorks targets. Motivation: To make it easier to verify that [`cc-rs`' conversion from `rustc` to Clang/LLVM triples](rust-lang/cc-rs#1431) is correct. Alternative: Pass `$ARCH-unknown-none` in the other VxWorks LLVM triples, I don't know anything about VxWorks, so am unsure which is the most correct option. CC target maintainer `@biabbas.` r? jieyouxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The targets
riscv32-wrs-vxworksandriscv64-wrs-vxworksuses the plain$ARCHLLVM triple, which LLVM normalizes to$ARCH-unknown-unknown, we should use$ARCH-unknown-linux-gnu$ABIwhich is consistent with the the other VxWorks targets.Motivation: To make it easier to verify that
cc-rs' conversion fromrustcto Clang/LLVM triples is correct.Alternative: Pass
$ARCH-unknown-nonein the other VxWorks LLVM triples, I don't know anything about VxWorks, so am unsure which is the most correct option.CC target maintainer @biabbas.
r? jieyouxu