Rollup of 8 pull requests #138459
Merged
Rollup of 8 pull requests #138459
+366
−717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After llvm/llvm-project#130382, RustWrapper needs to call CfiFunctionIndex::symbols() instead.
The targets used the plain `$ARCH` triple, which LLVM normalizes to `$ARCH-unknown-unknown`, which is inconsistent with the the other VxWorks targets which all use `$ARCH-unknown-linux-gnu$ABI`.
…i-obk
Add an opt-out in pretty printing for RTN rendering
Today, we render RPITIT types like `impl Sized { T::method(..) }` when RTN is enabled. This is very useful for diagnostics, since it's often not clear what the `impl Sized` type means by itself, and it makes it clear that that's an RPITIT that can be bounded using RTN syntax. See rust-lang#115624.
However, since we don't distinguish types that are rendered for the purposes of printing messages vs suggestions, this representation leaks into suggestions and turns into code that can't be parsed. This PR adds a new `with_types_for_suggestion! {}` and `with_types_for_signature! {}` options to the pretty printing architecture to make it clear that we're rendering a type for code suggestions.
This can be applied later as we find that we need it.
…petrochenkov
Delegation: allow foreign fns `reuse`
In example:
```rust
unsafe extern "C" {
fn foo();
}
reuse foo as bar;
```
Desugaring before:
```rust
fn bar() {
foo()
//~^ ERROR call to unsafe function `foo` is unsafe and requires unsafe function or block
}
```
after:
```rust
unsafe extern "C" fn bar() {
foo()
}
```
Fixes rust-lang#127412
r? `@petrochenkov`
Update mdbook to 0.4.47 This updates mdbook to bring in an important fix that enables the `output.html.hash-files` option to deal with network caching. Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0446 https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0447
minor interpreter cleanups - remove the `eval_inline_asm` hook that `@saethlin` added; the usage never materialized and he agreed with removing it - I tried merging `init_alloc_extra` and `adjust_global_allocation` and it didn't work; leave a comment as to why. Also, make the allocation code path a bit more clear by renaming `init_alloc_extra` to `init_local_allocation`. r? `@oli-obk`
…in42 Adapt to LLVM dropping CfiFunctionIndex::begin()/end() After llvm/llvm-project#130382, RustWrapper needs to call CfiFunctionIndex::symbols() instead.
…leLapkin Don't emit error within cast function, propagate it as a `CastError` Minor nitpick from rust-lang#136764. r? `@WaffleLapkin`
…hpratt Remove `feature = "hash_raw_entry"` The `hash_raw_entry` feature finished [fcp-close](rust-lang#56167 (comment)) back in August, and its remaining uses in the compiler have now been removed, so we should be all clear to remove it from `std`. Closes rust-lang#56167
…youxu Fix RISC-V VxWorks LLVM target triples The targets `riscv32-wrs-vxworks` and `riscv64-wrs-vxworks` uses the plain `$ARCH` LLVM triple, which LLVM normalizes to `$ARCH-unknown-unknown`, we should use `$ARCH-unknown-linux-gnu$ABI` which is consistent with the the other VxWorks targets. Motivation: To make it easier to verify that [`cc-rs`' conversion from `rustc` to Clang/LLVM triples](rust-lang/cc-rs#1431) is correct. Alternative: Pass `$ARCH-unknown-none` in the other VxWorks LLVM triples, I don't know anything about VxWorks, so am unsure which is the most correct option. CC target maintainer `@biabbas.` r? jieyouxu
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Post-merge analysis result Test differences
(and 12 additional diffs) |
|
📌 Perf builds for each rolled up PR:
previous master: 52daa7d835 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 13, 2025
|
Finished benchmarking commit (cbfdf0b): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.1%, secondary -3.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -4.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.166s -> 774.314s (0.02%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
reuse#138399 (Delegation: allow foreign fnsreuse)CastError#138423 (Don't emit error within cast function, propagate it as aCastError)feature = "hash_raw_entry"#138425 (Removefeature = "hash_raw_entry")r? @ghost
@rustbot modify labels: rollup
Create a similar rollup