Background
VisualEditor toolbar and overlays currently appears in the light theme. This is done via a rule inside the Vector skin. Removing this uncovers over issues. I cannot see a short term fix using invert that can be applied here, given VisualEditor itself is embedded in the page.
User story
As a reader I want my editor in night theme.
Requirements
- OOUI has support for night theme.
- T365764 has been fixed.
Requirement
Ensure that the VisualEditor toolbar and overlays in the Vector 2022 skin appear in the night theme, fixing specified issues to ensure all elements are legible and properly styled.
BDD
Feature: VisualEditor Toolbar and Overlays in Night Theme
Scenario: Ensure toolbar and overlays appear in night theme
Given the user has enabled night mode
When the user opens VisualEditor in the Vector 2022 skin
Then the toolbar and overlays should appear in the night theme
And all elements should be legible and properly styledTest Steps
Test Case 1: Verify VisualEditor Toolbar and Overlays in Night Theme
- Enable night mode.
- Open VisualEditor in the Vector 2022 skin.
- AC1: Confirm the toolbar appears in the night theme.
- AC2: Confirm overlays appear in the night theme.
- AC3: Confirm all elements are legible and properly styled.
Acceptance criteria
- Fix all issues defined in the scope section that result from enabling OOUI's night theme are fixed.
- The notheme class is removed from Vector and VisualEditor is opted into night theme with a note that we have approval from Olga/Editing team that this is "shippable".
- Fixing any issues with input elements which are using light theme e.g. musical notation/add code/chemical formulation are out of scope for this ticket - as they require changes in other extensions.
NOTE: If we do find another major issue that is not documented here, we will create another ticket and descope AC 2.
Scope
- Fix the omega menu
- Fix gallery caption
- Invert images in chemical and math formula areas.
Out of scope
Communication criteria - does this need an announcement or discussion?
N/A
Rollback plan
N/A
This task was created by Version 1.0.0 of the Web team task template using phabulous
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T366737#9919128 |
| 2 | ❓ | T366737#9919128 |
| 3 | ✅ | T366737#9919128 |
| 4 | ❌ | T366737#9919128 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T366737#9975770 |
| 2 | ✅ | T366737#9975770 |
| 3 | ✅ | T366737#9975770 |
